-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group skywire-cli visor subcommands #1132
Group skywire-cli visor subcommands #1132
Conversation
…ndpoints can't be fetched
The setup node PK stays the same This is related to
and
|
I think either we should move the logic of |
…utilities/pkg/skyenv@develop; clean up and other small tweaks
If we are moving towards the version of the config and visor being the same, we need to add a check during visor startup to see if the version of the config matches the version of the visor; if not then we need to stop the startup and print the required steps to update the config via the CLI. |
From the startup logs
printing this seems to be unnecessary as these logs provide pretty much the same info
|
We also need to update the changelog. |
…ve versioning. Add get version from git sources if version is unknown. Print command to regenerate config on version mismatch.
…compatible version errors
…compatible version errors
This PR changes the skywire-cli interface by adding another layer of sub-commands to
skywire-cli visor
This may affect any scripts which use these sub-commands
An effort was made to shorten some of the more lengthy descriptions, and to add shorthand flags wherever possible, especially for all of the existing
skywire-cli config gen
flags. The changes are extensive but not comprehensive.Did you run
make format && make check
?yes
Fixes #1072 #1138 #1134
Changes:
previous:
now:
How to test this PR:
go run cmd/skywire-cli/skywire-cli.go visor --help
I will update the documentation in a subsequent PR after this one is merged.