Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group skywire-cli visor subcommands #1132

Merged
merged 68 commits into from
Apr 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
3a3da6c
group `skywire-cli visor` subcommands
0pcom Mar 11, 2022
e63d513
update skywire cli interface
0pcom Mar 12, 2022
d1ce4bd
`make format && make check`
0pcom Mar 13, 2022
484c502
`skywire-cli config gen -o STDOUT`
0pcom Mar 13, 2022
0816418
update documentation
0pcom Mar 14, 2022
2a32e0f
update documentation
0pcom Mar 14, 2022
1ce1aea
fix make check error
0pcom Mar 14, 2022
a7cb39e
update documentation
0pcom Mar 14, 2022
3b1a47e
fix typo
0pcom Mar 14, 2022
048198b
fix typo
0pcom Mar 14, 2022
99f9f8d
fix documentation formatting
0pcom Mar 14, 2022
b19953b
fix typo
0pcom Mar 14, 2022
1cd2b05
eliminate writes when only reads are needed
0pcom Mar 18, 2022
5bdba01
visor no longer rewrites its config
0pcom Mar 22, 2022
d1cac60
merge develop into
mrpalide Mar 22, 2022
67602ec
fix linter errors and warns
mrpalide Mar 22, 2022
2e0f91f
refactor config update & add fallback to hardcoded values if server e…
0pcom Mar 24, 2022
74f2d60
continued refactoring.
0pcom Mar 25, 2022
a4bca27
continued refactoring.
0pcom Mar 25, 2022
a7d1b56
visor no longer writes to the config file. Fixed accidental recursion.
0pcom Mar 25, 2022
e2e1410
determine config parameters (hypervisor,dmsghttp) via map[string]inte…
0pcom Mar 25, 2022
97791ea
fix read config from stdin for visor
0pcom Mar 25, 2022
17295fa
refactor
0pcom Mar 25, 2022
45ae4c0
fix make check errors
0pcom Mar 25, 2022
8075e5e
color cobra & other asthetic improvements
0pcom Mar 26, 2022
d86e4b5
move completion from subcommand to -z flag
0pcom Mar 26, 2022
d58d02e
further tweaks
0pcom Mar 26, 2022
f15b566
fix service discovery and uptime tracker URLs accidentally switched
0pcom Mar 26, 2022
f0cac85
colorize setup-node help text
0pcom Mar 26, 2022
bc5319f
fix some make check errors
0pcom Mar 26, 2022
8337455
remove closing cliL in cli shutdown. It will close in dmsgpty shuttin…
mrpalide Mar 28, 2022
1b2b240
address requested changes, hide excess flags, logic cleanup for visor…
0pcom Mar 28, 2022
4cfd2c5
Merge branch 'refine-skywire-cli' of ssh://github.com/the-skycoin-pro…
0pcom Mar 28, 2022
fd3869b
fix appveyor tests & test deployment services
0pcom Mar 28, 2022
e098a9f
minor tweak to help menus; hide --all flag when showing all flags
0pcom Mar 28, 2022
e27aa3e
fix config update & other tweaks
0pcom Mar 29, 2022
4e66e57
rever cliL.Close()
mrpalide Mar 29, 2022
07293f2
check error for cliL.Close (fix appveyor error)
0pcom Mar 30, 2022
25ce5bf
Merge branch 'develop' into refine-skywire-cli
0pcom Mar 30, 2022
eb68bc9
nil error before returning for cliL.Close
0pcom Mar 30, 2022
c5067c1
change netErr.Temporary to netErr.Timeout ; fix golangci-lint error: …
0pcom Mar 30, 2022
d4a1d40
remove check config version from visorconfig.Parse
0pcom Mar 30, 2022
da0b293
fix appveyor errors for mac and windows
0pcom Mar 30, 2022
14f6201
change pushCloseStack on initCLI
mrpalide Mar 30, 2022
e9a9bc0
go get skywire-utilities@develop | fix new issues
mrpalide Mar 30, 2022
13e2eb3
cleanup removing unnecessary files. Drop unnecessary prefixes from va…
0pcom Mar 30, 2022
825f765
add viper to visor for handling config; change envs to match skywire-…
0pcom Mar 31, 2022
79289f2
fix visor wont start & other issues
0pcom Apr 2, 2022
31123d2
fix make check errors and add local folder (ignoring contents)
0pcom Apr 2, 2022
0f697df
fix appveyor errors
0pcom Apr 2, 2022
3e7c57f
fix appveyor errors
0pcom Apr 2, 2022
460d5f1
update documenttion and fix package path for config gen
0pcom Apr 2, 2022
aa01157
make format check
0pcom Apr 3, 2022
108b72f
update documentation / try to fix appveyor errors
0pcom Apr 3, 2022
8fd9bcc
update documentation
0pcom Apr 3, 2022
69b51ea
go get dmsg@develop | go get skywire-utilities@develop | go mod vendor
mrpalide Apr 4, 2022
09109d5
update golangci-lint to 1.44.2 in appveyor
mrpalide Apr 4, 2022
5c5e294
add not permitted error to whitelist
mrpalide Apr 4, 2022
767484f
fix nil pointer on tp.transport issue #1134
mrpalide Apr 4, 2022
c1b817c
add autostart flag on update config
mrpalide Apr 4, 2022
d855e23
add --dmsghttp flag to update dmsghttp-config file from github
mrpalide Apr 4, 2022
72bdb4b
update CHANGELOG | fix linter
mrpalide Apr 4, 2022
a76791b
check config version against visor version & error on mismatch. Impro…
0pcom Apr 5, 2022
9077689
remove dmsghttp-config update logic
mrpalide Apr 5, 2022
fb7f41c
fix logging & update logic for printing config gen instructions on in…
0pcom Apr 5, 2022
d4ab914
fix logging & update logic for printing config gen instructions on in…
0pcom Apr 5, 2022
c8a6250
make format check
0pcom Apr 5, 2022
dbe524d
Merge branch 'develop' into refine-skywire-cli
mrpalide Apr 6, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/skywire.json
/apps/
/skywire/
/local*
/local/*
/transport_logs
/dmsgpty

Expand Down
35 changes: 34 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,43 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Changed
- config updated to `v1.1.1`
- remove dsmghttp migration to skywire-visor starting
- only support current version of config
- config version reflects current visor version
- refine and restructure help commands user interface
- shorthand flags for commands
- group skywire-cli visor subcommands
- hide excess flags
- make help text fit within default 80x24 terminal
- rename `skywire-cli config gen -r --replace` flag to `-r --regen`
- remove config path from V1 struct
- remove all instance of the visor writing to the config file except via api
- remove path to dmsghttp-config.json from config
- revise versioning - move to skyenv
- remove transports cache from visor initialization and check them before make route

### Added
- added `add-rhv` and `disable-rhv` flags to `skywire-visor` for adding remote hypervisor PK and disable remote hypervisor PK(s) on config file
- shorthand flags for commands
- blue & white color scheme with coloredcobra
- ascii art text modal of program name to help menus
- `--all` flag to skywire-cli & visor to show extra flags
- `skywire-cli config gen -n --stdout` write config to stdout
- `skywire-cli config gen -w, --hide` dont print the config to the terminal
- `skywire-cli config gen --print` parse test ; read config from file & print
- `skywire-cli config gen -a, --url` services conf (default "conf.skywire.skycoin.com")
- fetch service from endpoint
- `skywire-cli visor app` app settings command
- `skywire-cli visor route` view and set rules command
- `skywire-cli visor tp` view and set transports command
- `skywire-cli visor vpn` vpn interface command
- create global varibles for config path, working dir, path to running binary
- root permissions detection
- error on different version config / visor
- display update command on config version error
- support for piping config generated by skywire-cli to skywire-visor via stdin
- BuildInfo global variable to skyenv
- support for detecting skywire version when `go run`


## 0.6.0

Expand Down Expand Up @@ -80,7 +113,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## 0.2.0 - 2020.04.02

### Added
### Added

- added `--retain-keys` flag to `skywire-cli visor gen-config` command
- added `--secret-key` flag to `skywire-cli visor gen-config` command
Expand Down
13 changes: 13 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,23 @@ BUILDINFO_COMMIT := -X $(BUILDINFO_PATH).commit=$(COMMIT)
BUILDTAGINFO := -X $(PROJECT_BASE)/pkg/visor.BuildTag=$(BUILDTAG)

BUILDINFO?=$(BUILDINFO_VERSION) $(BUILDINFO_DATE) $(BUILDINFO_COMMIT) $(BUILDTAGINFO)
INFO?=$(VERSION) $(DATE) $(COMMIT) $(BUILDTAG)

BUILD_OPTS?="-ldflags=$(BUILDINFO)" -mod=vendor $(RACE_FLAG)
BUILD_OPTS_DEPLOY?="-ldflags=$(BUILDINFO) -w -s"

buildinfo:
@echo $(INFO)

version:
@echo $(VERSION)

date:
@echo $(DATE)

commit:
@echo $(COMMIT)

check: lint test ## Run linters and tests

check-windows: lint-windows test-windows ## Run linters and tests on appveyor windows image
Expand Down
2 changes: 1 addition & 1 deletion cmd/apps/skychat/chat.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ import (
"github.com/skycoin/skywire-utilities/pkg/buildinfo"
"github.com/skycoin/skywire-utilities/pkg/cipher"
"github.com/skycoin/skywire-utilities/pkg/netutil"
"github.com/skycoin/skywire-utilities/pkg/skyenv"
"github.com/skycoin/skywire/pkg/app"
"github.com/skycoin/skywire/pkg/app/appnet"
"github.com/skycoin/skywire/pkg/routing"
"github.com/skycoin/skywire/pkg/skyenv"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion cmd/apps/skysocks-client/skysocks-client.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ import (
"github.com/skycoin/skywire-utilities/pkg/buildinfo"
"github.com/skycoin/skywire-utilities/pkg/cipher"
"github.com/skycoin/skywire-utilities/pkg/netutil"
"github.com/skycoin/skywire-utilities/pkg/skyenv"
"github.com/skycoin/skywire/internal/skysocks"
"github.com/skycoin/skywire/pkg/app"
"github.com/skycoin/skywire/pkg/app/appnet"
"github.com/skycoin/skywire/pkg/routing"
"github.com/skycoin/skywire/pkg/skyenv"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion cmd/apps/skysocks/skysocks.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ import (
"github.com/sirupsen/logrus"

"github.com/skycoin/skywire-utilities/pkg/buildinfo"
"github.com/skycoin/skywire-utilities/pkg/skyenv"
"github.com/skycoin/skywire/internal/skysocks"
"github.com/skycoin/skywire/pkg/app"
"github.com/skycoin/skywire/pkg/app/appnet"
"github.com/skycoin/skywire/pkg/routing"
"github.com/skycoin/skywire/pkg/skyenv"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion cmd/apps/vpn-client/vpn-client.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import (
ipc "github.com/james-barrow/golang-ipc"

"github.com/skycoin/skywire-utilities/pkg/cipher"
"github.com/skycoin/skywire-utilities/pkg/skyenv"
"github.com/skycoin/skywire/internal/vpn"
"github.com/skycoin/skywire/pkg/app"
"github.com/skycoin/skywire/pkg/app/appevent"
"github.com/skycoin/skywire/pkg/skyenv"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion cmd/apps/vpn-server/vpn-server.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ import (
"github.com/sirupsen/logrus"

"github.com/skycoin/skywire-utilities/pkg/cipher"
"github.com/skycoin/skywire-utilities/pkg/skyenv"
"github.com/skycoin/skywire/internal/vpn"
"github.com/skycoin/skywire/pkg/app"
"github.com/skycoin/skywire/pkg/app/appnet"
"github.com/skycoin/skywire/pkg/routing"
"github.com/skycoin/skywire/pkg/skyenv"
)

const (
Expand Down
19 changes: 19 additions & 0 deletions cmd/setup-node/commands/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"io/ioutil"
"os"

cc "github.com/ivanpirog/coloredcobra"
"github.com/sirupsen/logrus"
"github.com/skycoin/skycoin/src/util/logging"
"github.com/spf13/cobra"
Expand Down Expand Up @@ -37,6 +38,11 @@ func init() {
var rootCmd = &cobra.Command{
Use: "setup-node [config.json]",
Short: "Route Setup Node for skywire",
Long: `
┌─┐┌─┐┌┬┐┬ ┬┌─┐ ┌┐┌┌─┐┌┬┐┌─┐
└─┐├┤ │ │ │├─┘───││││ │ ││├┤
└─┘└─┘ ┴ └─┘┴ ┘└┘└─┘─┴┘└─┘`,

Run: func(_ *cobra.Command, args []string) {
mLog := logging.NewMasterLogger()
log := logging.MustGetLogger(tag)
Expand Down Expand Up @@ -117,6 +123,19 @@ func prepareMetrics(log logrus.FieldLogger) setupmetrics.Metrics {

// Execute executes root CLI command.
func Execute() {
cc.Init(&cc.Config{
RootCmd: rootCmd,
Headings: cc.HiBlue + cc.Bold,
Commands: cc.HiBlue + cc.Bold,
CmdShortDescr: cc.HiBlue,
Example: cc.HiBlue + cc.Italic,
ExecName: cc.HiBlue + cc.Bold,
Flags: cc.HiBlue + cc.Bold,
FlagsDataType: cc.HiBlue,
FlagsDescr: cc.HiBlue,
NoExtraNewlines: true,
NoBottomNewline: true,
})
if err := rootCmd.Execute(); err != nil {
panic(err)
}
Expand Down
Loading