Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-hooks(chore): fix prelint tsc run script #1895

Merged
merged 1 commit into from
Aug 20, 2024
Merged

cli-hooks(chore): fix prelint tsc run script #1895

merged 1 commit into from
Aug 20, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 19, 2024

... by not type checking node_modules folder. fixes #1894

@filmaj filmaj added semver:patch tests M-T: Testing work only area:typescript issues that specifically impact using the package from typescript projects pkg:cli-hooks applies to `@slack/cli-hooks` labels Aug 19, 2024
@filmaj filmaj requested a review from zimeg August 19, 2024 13:09
@filmaj filmaj self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (d386133) to head (d1c484a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1895   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          34       34           
  Lines        7648     7648           
  Branches      374      374           
=======================================
  Hits         6872     6872           
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 94.94% <ø> (ø)
cli-test 94.77% <ø> (ø)
oauth 76.53% <ø> (ø)
socket-mode 59.59% <ø> (ø)
web-api 96.57% <ø> (ø)
webhook 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj merged commit deb51ea into main Aug 20, 2024
30 checks passed
@filmaj filmaj deleted the ci-fix-hooks branch August 20, 2024 11:46
@mwbrooks mwbrooks added this to the [email protected] milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:cli-hooks applies to `@slack/cli-hooks` semver:patch tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CI builds for cli-hooks package failure
2 participants