-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (web-api / types): Add support for assistant.threads.* API #2033
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
+ Coverage 92.48% 92.51% +0.02%
==========================================
Files 37 37
Lines 9946 9981 +35
Branches 633 633
==========================================
+ Hits 9199 9234 +35
Misses 747 747
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -0,0 +1,29 @@ | |||
export interface AssistantThreadStartedEvent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filmaj These are used in the implementation for Bolt, but figured they should go in now. Let me know if you prefer these to be separate!
packages/web-api/src/types/response/AdminAppsActivitiesListResponse.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one suggestion re: factoring out a type and specifying "at least 1" (if applicable).
As for the formatting, I recently changed the linter (#2006), and I don't think I re-ran generating the response types since then. @misscoded can you try resetting your node_modules
folder and running the lint task locally? rm -rf node_modules package-lock.json && npm it
. I have a feeling that will fix the response types and tighten up the diff in this PR.
Summary
Adds support for
assistant.threads.*
endpoints, including:Requirements (place an
x
in each[ ]
)