Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth module: SQLAlchemy v2 compatibility #1327

Closed
seratch opened this issue Feb 10, 2023 · 0 comments · Fixed by #1335
Closed

OAuth module: SQLAlchemy v2 compatibility #1327

seratch opened this issue Feb 10, 2023 · 0 comments · Fixed by #1335
Assignees
@seratch
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented good first issue oauth Version: 3x
Milestone
3.20.0

Comments

@seratch
Copy link
Member

seratch commented Feb 10, 2023

As reported at slackapi/bolt-python#822, our StateStore/InstallationStore implementations are not compatible with SQLAlchemy v2.

Reproducible in:

The Slack SDK version

Any versions

Python runtime version

Any versions

OS info

Any operating systems

Steps to reproduce:

Refer to slackapi/bolt-python#822

Expected result:

The state parameter validation succeeds

Actual result:

Always fails with an exception
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x oauth good first issue labels Feb 10, 2023
@seratch seratch added this to the 3.20.0 milestone Feb 10, 2023
@seratch seratch self-assigned this Feb 10, 2023
seratch added a commit to seratch/python-slack-sdk that referenced this issue Feb 17, 2023
@seratch
Fix slackapi#1327 OAuth module: SQLAlchemy v2 compatibility
967ef02
@seratch seratch mentioned this issue Feb 17, 2023
Merged
16 tasks
seratch added a commit that referenced this issue Feb 17, 2023
@seratch
Fix #1327 OAuth module: SQLAlchemy v2 compatibility (#1335)
aabe5b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented good first issue oauth Version: 3x
Projects
None yet
Milestone
3.20.0
Development

Successfully merging a pull request may close this issue.

Fix #1327 OAuth module: SQLAlchemy v2 compatibility seratch/python-slack-sdk
1 participant
@seratch