Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1327 OAuth module: SQLAlchemy v2 compatibility #1335

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 17, 2023

Summary

This pull request resolves #1327. I've confirmed that the code works with both v1.4 and v2.0.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x oauth labels Feb 17, 2023
@seratch seratch added this to the 3.20.0 milestone Feb 17, 2023
@seratch seratch self-assigned this Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1335 (967ef02) into main (8dc50a8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         111      111           
  Lines       11394    11394           
=======================================
  Hits         9731     9731           
  Misses       1663     1663           
Impacted Files Coverage Δ
...dk/oauth/installation_store/sqlalchemy/__init__.py 98.23% <100.00%> (ø)
slack_sdk/oauth/state_store/sqlalchemy/__init__.py 90.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit aabe5b9 into slackapi:main Feb 17, 2023
@seratch seratch deleted the issue-1327-sqlalchemy-v2 branch February 17, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented oauth Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth module: SQLAlchemy v2 compatibility
1 participant