Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "removing values.Map from BaseMessage proto as Beholder only supports root level protos (#876)" #881

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

patrickhuie19
Copy link
Contributor

This reverts commit b772997 due to some WASM test failures

…upports root level protos (#876)"

This reverts commit b772997.
@patrickhuie19 patrickhuie19 requested review from a team as code owners October 23, 2024 01:39
@patrickhuie19 patrickhuie19 requested review from vyzaldysanchez and removed request for a team October 23, 2024 01:39
@vyzaldysanchez vyzaldysanchez merged commit c5c856e into main Oct 23, 2024
10 checks passed
@vyzaldysanchez vyzaldysanchez deleted the revert/root-level-protos branch October 23, 2024 01:52
patrickhuie19 added a commit that referenced this pull request Oct 23, 2024
…supports root level protos (#876)" (#881)

This reverts commit c5c856e.
patrickhuie19 added a commit that referenced this pull request Oct 25, 2024
…supports root level protos (#876)" (#881) (#886)

This reverts commit c5c856e.
patrickhuie19 added a commit that referenced this pull request Oct 25, 2024
…supports root level protos (#876)" (#881) (#886)

This reverts commit c5c856e.

(cherry picked from commit eed6b5f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants