bumping common to chainlink-aptos #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The chainlink-common version used here: github.com/smartcontractkit/chainlink-common v0.3.1-0.20241210195010-36d99fa35f9f The reason I used common release/2.19.0-aptos is because that version is used in the core for the latest release. Do you think its reasonable to ship same version of the common across core and LOOPP's in this case and relax this requirement "DO NOT MERGE - this go.mod bump does not reference a commit on the main branch of common"? |
jmank88
approved these changes
Dec 13, 2024
samsondav
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom branch of mercury bumping common to
release/2.19.0-aptos.DO NOT MERGE - this go.mod bump does not reference a commit on the
mainbranch of common