Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chainlink-data-streams #15673

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

pkcll
Copy link
Contributor

@pkcll pkcll commented Dec 12, 2024

Bump chainlink-data-streams to smartcontractkit/chainlink-data-streams#92

@pkcll pkcll requested review from a team as code owners December 12, 2024 23:02
@pkcll pkcll requested a review from patrickhuie19 December 12, 2024 23:02
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. TestPollManager_Stop failed:go_core_tests

Source of Error:
Run tests	2024-12-12T23:08:59.0062935Z --- FAIL: TestPollManager_Stop (4.00s)
Run tests	2024-12-12T23:08:59.0063936Z logger.go:146: 2024-12-12T23:07:05.999Z	INFO	PollManager	fluxmonitorv2/poll_manager.go:237	exiting hibernation mode, reactivating contract	{"version": "unset@unset"}
Run tests	2024-12-12T23:08:59.0065948Z logger.go:146: 2024-12-12T23:07:05.999Z	DEBUG	PollManager	fluxmonitorv2/poll_manager.go:298	resetting idleTimer	{"version": "unset@unset", "pollFrequency": "200ms", "idleDuration": "1s", "startedAt": 1734044825, "timeUntilIdleDeadline": "26.023µs"}
Run tests	2024-12-12T23:08:59.0070123Z logger.go:146: 2024-12-12T23:07:06.000Z	DEBUG	PollManager	fluxmonitorv2/poll_manager.go:320	disabling roundTimer, as the round is already past its timeout by 5.156µs	{"version": "unset@unset", "pollFrequency": "200ms", "idleDuration": "1s", "timesOutAt": 1734044826}
Run tests	2024-12-12T23:08:59.0071201Z poll_manager_test.go:362: 
Run tests	2024-12-12T23:08:59.0072032Z 	Error Trace:	/home/runner/work/chainlink/chainlink/core/services/fluxmonitorv2/poll_manager_test.go:362
Run tests	2024-12-12T23:08:59.0072647Z 	Error: 	Should be true
Run tests	2024-12-12T23:08:59.0073030Z 	Test: 	TestPollManager_Stop
Run tests	2024-12-12T23:08:59.0073301Z FAIL
Run tests	2024-12-12T23:08:59.0073759Z FAIL	github.com/smartcontractkit/chainlink/v2/core/services/fluxmonitorv2	62.245s

Why: The test TestPollManager_Stop failed because an assertion expected to be true was false. This indicates that the PollManager did not behave as expected during the test, possibly due to timing issues or incorrect state management.

Suggested fix: Review the PollManager logic, especially around the Stop method and its state transitions. Ensure that the timers and state changes are correctly handled and synchronized. Add more detailed logging or assertions to diagnose the exact failure point.

@pkcll pkcll added release-preview build-test-image Will build the e2e test image in integration-tests workflow for PRs build-publish Build and Publish image to SDLC and removed release-preview build-test-image Will build the e2e test image in integration-tests workflow for PRs labels Dec 12, 2024
@pkcll
Copy link
Contributor Author

pkcll commented Dec 13, 2024

@krebernisak @bolekk @patrickhuie19 The CPU issue could effect any LOOPP, it needs to be fixed across the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-publish Build and Publish image to SDLC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants