Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local_context_data and config_context as JSON objects #23

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

amhn
Copy link
Contributor

@amhn amhn commented Apr 20, 2022

This PR creates the necessary changes to fix smutel/terraform-provider-netbox#59 in the terraform netbox provider.

With this change local_context_data is sent as JSON object instead of string and both config_context and local_context_data are read as JSON objects.

Fixes #25

@auto-add-label auto-add-label bot added the bug Something isn't working label Apr 20, 2022
@auto-assign auto-assign bot requested a review from smutel April 20, 2022 14:52
@smutel
Copy link
Owner

smutel commented Apr 21, 2022

@smutel
Copy link
Owner

smutel commented Apr 22, 2022

Could you please rebase your branch ?

@smutel
Copy link
Owner

smutel commented Apr 22, 2022

Fix #25

@smutel
Copy link
Owner

smutel commented Apr 22, 2022

Could you please rebase your branch, again ?

@smutel smutel merged commit 2c35e6e into smutel:main Apr 22, 2022
@amhn amhn deleted the local_context branch August 13, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants