Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local_context_data and config_context as JSON objects #22

Closed
wants to merge 1 commit into from

Conversation

amhn
Copy link
Contributor

@amhn amhn commented Apr 17, 2022

This PR creates the necessary changes to fix smutel/terraform-provider-netbox#59 in the terraform netbox provider.

With this change local_context_data is sent as JSON object instead of string and both config_context and local_context_data are read as JSON objects.

@auto-add-label auto-add-label bot added the bug Something isn't working label Apr 17, 2022
@auto-assign auto-assign bot requested a review from smutel April 17, 2022 19:56
@smutel
Copy link
Owner

smutel commented Apr 18, 2022

Hello,

Thank you for this PR.

The netbox folder will be override by the GitHub CI.

Please create a patch for the JSON swagger file in the patch folder called swagger-v3.0.11-localcontextdata-json.patch for example.

Once this PR will be merged, the GitHub CI will generate the go-netbox library.

Thanks.

@amhn
Copy link
Contributor Author

amhn commented Apr 18, 2022

That's what I tried with patchs/swagger-v3.0.11-device-vm-localcontextdata.patch

Do I need to change that file somehow?

@smutel
Copy link
Owner

smutel commented Apr 18, 2022

I don't think so. So you can remove all other change in this PR and keep only the patch file.

@amhn
Copy link
Contributor Author

amhn commented Apr 18, 2022

Done.
Thank you for your help

@smutel
Copy link
Owner

smutel commented Apr 19, 2022

I created a thread here : https://github.521000.bestmunity/t/403-resource-not-accessible-by-integration/245926 to get help on the github action. It worked before so I don't understand what's going on.

@smutel
Copy link
Owner

smutel commented Apr 20, 2022

Could you please create a new branch on your repository with this change and open a new PR to see if the issue is the same ?

@amhn
Copy link
Contributor Author

amhn commented Apr 20, 2022

#23

@amhn amhn closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local_context_data on virtual machine is asking for a string but needs te be JSON
2 participants