fix: Allow setting local_context_data

[amhn]

This PR fixes #59

local_context_data still needs to be a string in the resource due to limitations in terraform.
This fix needs smutel/go-netbox#22 merged and updated in vendor/.

local_context_data can be specified as follows or as string

resource "netbox_virtualization_vm" "virtual_machines" {
  […]
      local_context_data = jsonencode(
            {
                    foo = "bar"
                    number = 1
            }
        )
}

[smutel]

Hello. Could you please rebase your branch and use go-netbox/v3.0.1. Thanks.

[smutel]

Hello,

It seems that the master in your fork of my project is not up to date.
For testing, it will be easier for me to rebase your branch from the master of this project.

Thanks.

[amhn]

Done. Pushed your master to my fork. Changes for this PR are in https://github.com/amhn/terraform-provider-netbox/tree/local_context_data

[smutel]

I tested this code with Netbox 3.0.11 and I have the error below:

netbox_virtualization_vm.vm_test: Modifying... [id=23]
╷
│ Error: response status code does not match any response statuses defined for this endpoint in the swagger spec (status 400): {}
│ 
│   with netbox_virtualization_vm.vm_test,
│   on main.tf line 271, in resource "netbox_virtualization_vm" "vm_test":
│  271: resource "netbox_virtualization_vm" "vm_test" {

[amhn]

I just pushed a new commit with a fix if local_context_data is empty or not defined. I did not test that case.

I tried different things and could not reproduce a status code of 400. Also using netbox-3.0.11

The following all worked:

• no local_context_data
• local_context_data = ""
• local_context_data = jsonencode({})
• local_context_data = jsonencode({foo = "bar"})

Which branch did you test with? My master is identical to yours, changes are in the local_context_data branch.
Can you give me a .tf file that fails?
Can you record the traffic between netbox and terraform with e.g. tcpdump?

I suspect you were on the wrong branch. Because that is the behaviour before my changes.

(That the error message from the 400 is not printed, is another issue worth investigating. I suspect this is due to swagger.json not mentioning 400 as a possible response status)

[smutel]

My bad, I tested with your master branch. Everything looks good. Thanks.