Added #2353: Add ability to tie locations to companies #10705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locations are the last big part of the application that can't be tied to companies. This can be a problem with FullMultipleCompanySupport, because you can't restrict the visibility of locations to the company of the users. In order to change this, add a company_id to the locations table and wire everything up in the views and controllers. Aditionally add a new formatter to filter the locations to a specific company, like it is done for assets.
With FullMultipleCompanySupport enabled, a standard user can only see locations from its own company. This is a backward incompatible change. To preserve backward compatibility, locations with company_id = null are shown to all users. Note that if a scoped user with permissions to change locations updates a location, the location inherits the company of the user.
To ease transition after tying locations to companies introduce bulk operations to locations. For now only bulk edit for a few fields (including company) is supported. This can easily be extended in the future.
|
@snipe @uberbrady: Now that V6 is out, can someone please look at this PR? Is the general idea useful and acceptable upstream? I'm willing to work on the details if I get feedback. |
This was referenced Sep 13, 2022
|
@snipe - is the ability to tie locations to companies now available? Seems to be a lot of conflicting threads about this, thanks in advance! |
13 tasks
|
There is an updated PR #12577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Locations are the last big part of the application that can't be tied to companies.
This can be a problem with FullMultipleCompanySupport, because you can't restrict the visibility of locations to the company of the users.
The first commit wires everything up so that locations have a company_id and are properly scoped with FullMultipleCompanySupport.
The second commit preserve backward compatibility with the existing behaviour, as locations with company_id = null are shown regardless of the users company. I'm not sure if this is worth it and personally I don't need this for my organisation, but I included this just to show how it could be made possible.
The third commit introduces bulk operations for locations to ease transition for this new feature.
Fixes #2353
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I developed and tested this feature with V5 and rebased it later to V6. All tests passed on this version either.
I checked that the correct locations are shown as SuperUser and scoped user with FullMultipleCompanySupport.
Checklist: