Added validation around department_id in API patch request #13575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply adds the smallest amount of validation around the
department_id
field when sending an API PATCH request for a user. It was pointed out that sendingresulted in a success message but didn't actually a change. This is because the endpoint actually needs this format
I just added a validation rule that says the
department_id
, if provided, needs to exist in the departments table.I started to go down the path of testing validation for all inputs but decided to keep it simple and focused in this PR.
One thing I noticed is that even though our docs say
two_factor_enrolled
, andtwo_factor_optin
can be updated via this endpoint those properties aren't in the User model'sfillable
array so changes are not applied. I think the docs should be updated to remove those fields right?Type of change