Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing test #13577

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Fixed failing test #13577

merged 1 commit into from
Sep 8, 2023

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Sep 7, 2023

Description

Follow up to #13576 that follows up #13575 and fixes some failed assertions.


Continuing my comments from #13576, it looks like ChipperCI isn't actually pulling down the changes included in this PR...The build shows assertions from develop but not what is included in this branch...
CleanShot 2023-09-07 at 16 50 11@2x

I'm trusting GitHub Actions is pulling and running the correct branch...

@what-the-diff
Copy link

what-the-diff bot commented Sep 7, 2023

PR Summary

  • Enhancements to testCanUpdateUserViaPatch method
    The method in UsersUpdateTest.php has been updated to more rigorously test the updates to user attributes. This is an important quality assurance change that ensures our system correctly handles user information updates. A vast array of attributes including personal details like first name, last name, and contact details; and professional details like job title, manager, company department etc. are now being checked for correct updates.

  • Group Membership Check
    Post the update process, a new assertion has been added to confirm that a user is made part of the expected groups. This ensures that user-based group policies are correctly enforced.

  • Specific Failure Messages
    The test assertions have been further improved with the addition of specific failure messages. This will aid developers in understanding and rectifying the issues causing the updates to fail, improving the overall stability and reliability of our system.

@snipe snipe merged commit dc74fb1 into snipe:develop Sep 8, 2023
@marcusmoore marcusmoore deleted the fixes/improve-testcase branch September 11, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants