Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Potential Exception #15057

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fixes Potential Exception #15057

merged 3 commits into from
Jul 10, 2024

Conversation

spencerrlongg
Copy link
Collaborator

Description

Fixes an issue where assignedTo could be null resulting in an exception when ->is() is called.

Fixes SC-23212

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test included

Test Configuration:

  • PHP version: 8.1
  • MySQL version 8.2

@spencerrlongg spencerrlongg requested a review from snipe as a code owner July 9, 2024 16:41
@spencerrlongg spencerrlongg requested review from marcusmoore and snipe and removed request for snipe July 9, 2024 16:41
Copy link

what-the-diff bot commented Jul 9, 2024

PR Summary

  • Enhanced User Comparison in Checkout Process
    The logic in handling checkout acceptances was refined in the application. Now, to further build robustness, the code reliably compares if an item checked out is indeed assigned to the appropriate user. This is done using advanced null-proof comparison techniques.

  • Improved Testing for Accessory Acceptance Mechanism
    In order to ensure that our accessory acceptance process works as expected, we've introduced expanded testing capabilities that check if a user can accept an item that is not assigned to them. This test creates a hypothetical user and assigns an item to them, attempting to accept the item and expecting to receive an appropriate error message. This helps us ensure that items only get accepted by their rightful assignees, enhancing the overall security and integrity of our checkout system.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

@snipe
Copy link
Owner

snipe commented Jul 10, 2024

Nice, thank you Spencer!

@snipe snipe merged commit fb10c14 into snipe:develop Jul 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants