Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Potential Exception #15057

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fixes Potential Exception #15057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8650923
new branch cuz test merge
spencerrlongg Jul 8, 2024
33b2c7b
push so i can do something else
spencerrlongg Jul 9, 2024
6625529
test working
spencerrlongg Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Models/CheckoutAcceptance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function isPending()
*/
public function isCheckedOutTo(User $user)
{
return $this->assignedTo->is($user);
return $this->assignedTo?->is($user);
}

/**
Expand Down
20 changes: 20 additions & 0 deletions tests/Feature/CheckoutAcceptances/Ui/AccessoryAcceptanceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
namespace Tests\Feature\CheckoutAcceptances\Ui;

use App\Models\Accessory;
use App\Models\Asset;
use App\Models\CheckoutAcceptance;
use App\Models\User;
use App\Notifications\AcceptanceAssetAcceptedNotification;
use App\Notifications\AcceptanceAssetDeclinedNotification;
use Notification;
Expand Down Expand Up @@ -76,4 +78,22 @@ function (AcceptanceAssetDeclinedNotification $notification) use ($acceptance) {
}
);
}

public function testUserIsNotAbleToAcceptAnAssetAssignedToADifferentUser()
{
Notification::fake();

$otherUser = User::factory()->create();

$acceptance = CheckoutAcceptance::factory()
->pending()
->for(Asset::factory()->laptopMbp(), 'checkoutable')
->create();

$this->actingAs($otherUser)
->post(route('account.store-acceptance', $acceptance), ['asset_acceptance' => 'accepted'])
->assertSessionHas(['error' => trans('admin/users/message.error.incorrect_user_accepted')]);

$this->assertNull($acceptance->fresh()->accepted_at);
}
}
Loading