-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use destroy_all instead of delete_all when deleting shipments
In Order#ensure_available_shipping_rates. We should trigger ActiveRecord callbacks unless we have a good reason not to. In this case at least the `dependent: :delete_all` on inventory units was being skipped. This caused foreign key errors in our app since we have foreign keys set up.
- Loading branch information
1 parent
81cbc5c
commit e7450ec
Showing
2 changed files
with
17 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters