Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky checkout feature spec #2910

Closed
kennyadsl opened this issue Oct 11, 2018 · 0 comments
Closed

Flaky checkout feature spec #2910

kennyadsl opened this issue Oct 11, 2018 · 0 comments
Assignees
@kennyadsl

Comments

@kennyadsl
Copy link
Member

kennyadsl commented Oct 11, 2018 •
edited
Loading

We have some random failures on the CI, for example this one on master.

This always happens on the same spec: spec/features/checkout_spec.rb:364 and looking at the artifacts on the build and there is a clear evidence that it is an issue with credit card.

Error on Ci

This error happens when the credit card number is not valid, that's the only check done on the Bogus payment method used in specs.

I think this is related to these issues:

There are some suggested solutions around, like this one but I'd like to avoid changing the normal Capybara behavior as much as possible.
@kennyadsl kennyadsl mentioned this issue Oct 11, 2018
Merged
kennyadsl added a commit to nebulab/solidus that referenced this issue Oct 11, 2018
@kennyadsl
Fill credit card input with force in checkout spec
361fc40 
This fixes the flaky spec described into solidusio#2910.

Capybara fill_in sometime does not fill the input with the whole
string. This commit will fill it with js bypassing the default
behavior.
@kennyadsl kennyadsl self-assigned this Oct 16, 2018
aitbw pushed a commit to aitbw/solidus that referenced this issue Feb 5, 2019
@kennyadsl @aitbw
Fill credit card input with force in checkout spec
80d3642 
This fixes the flaky spec described into solidusio#2910.

Capybara fill_in sometime does not fill the input with the whole
string. This commit will fill it with js bypassing the default
behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kennyadsl