Fill credit card input with force in checkout spec #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the flaky spec described into solidusio#2910. Capybara fill_in sometime does not fill the input with the whole string. This commit will fill it with js bypassing the default behavior.
kennyadsl
force-pushed
the
fix-flaky-spec
branch
from
48c8a8e to
361fc40
Compare
|
I'm re-pushing this branch several times to see if this really fixes it |
kennyadsl
force-pushed
the
fix-flaky-spec
branch
from
4708df8 to
361fc40
Compare
|
This seems to work, I don't love it but can't find any other solution at the moment. WDYT? |
tvdeyen
approved these changes
Oct 12, 2018
|
Merged because all PRs are currently suffering of breaking builds. |
3 tasks
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 4, 2019
These input are controlled by a js plugin (payment.js) that messes up with Capybara and gives us a lot of flaky specs. By using this hacky solution we are sure input are filled correctly, see also solidusio#2911.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the flaky spec described into #2910.
Capybara
fill_insometime does not fill the input with all the string provided so this fix will fill it with JS bypassing the default behavior.