Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move page title and action buttons into a sticky header #630

Closed
Mandily opened this issue Dec 29, 2015 · 8 comments
Closed

Move page title and action buttons into a sticky header #630

Mandily opened this issue Dec 29, 2015 · 8 comments
Assignees

Comments

@Mandily
Copy link
Contributor

Mandily commented Dec 29, 2015

Currently the page title and action buttons are scrollable with the rest of the page content. I’d like to place these items in a sticky area of the page so that the user can always see what page they’re on and have easy access to functions like adding new items to lists.

The page title would be left aligned and the action buttons would be right aligned to the screen. The content in the page would remain fixed and centered. The page title would truncate if it was exceptionally long and the screen was too small for it to fit on one line, although if the user hovered over it they could see the full page title in a browser styled tooltip.

See the mockup for details. (ignore the left nav visual design for now)

Please let me know your thoughts in the comments below.

6-sticky-header

@BenMorganIO
Copy link
Contributor

👍 that's a great improvement

@tvdeyen
Copy link
Member

tvdeyen commented Dec 30, 2015

Would love to see this happening. This is a great improvement.

As next step I would love to see the content not being centered and narrowed any more. It does not fit into the overall look anymore and is a waste of screen space.

@cbrunsdon How do you plan to release all of these backend improvements? As the individual PRs are great, releasing them individually would lead to a very inconsistent UI. So, I guess that if all UI PRs landed, we will release them all together, right?

@Mandily
Copy link
Contributor Author

Mandily commented Dec 30, 2015

I haven't posted all 4 of the following issues up yet, but we're starting to plan for the 1.3 release.
Assuming we don't run into any problems along the way, we'd like to get a sticky header, 100% width, tabs and moving the settings right side navigation into the left nav in 1.3.

@cbrunsdon
Copy link
Contributor

@tvdeyen What is up there now (menu on the left, some colour changes) are what we're targeting for 1.2 (which we're hoping to get out the door sooner rather than later).

But aye, what @Mandily said. Kevin is AFK for the week but Hawth, Mandily and myself sat down yesterday and tried to see what would target 1.3 release. I think we came up with a good balance of consistency but still reasonable to do in a single release.

We'll have to play it by ear as the work and feedback comes in, but will keep the releases in mind.

@tvdeyen
Copy link
Member

tvdeyen commented Dec 30, 2015

Ok, sounds like a good plan. Besides the colour (British Columbia ^_^, love that) changes in #603. This would lead to a strange mix of colours in the admin UI. I would move the colour changes all together in one release (1.3 then). Also #629 would be a better candidate for 1.3.

Moving around the navigation and flash notices is ok IMO, but having two colour themes is not.

How do you think about it @cbrunsdon @Mandily ?

This was referenced Dec 30, 2015
@Mandily
Copy link
Contributor Author

Mandily commented Feb 12, 2016

To update this ticket to reflect conversations outside of this thread - rebranding and colour changes will be in 1.4. Only structural things on the UI side will be addressed in 1.3.

@Mandily
Copy link
Contributor Author

Mandily commented Apr 18, 2016

As per the two reference issues above, work has been done to remove the grid from the header and align the title and buttons to the outer sides. We're still in talks as to whether the stickiness is useful at this point.

@jhawthorn jhawthorn added the UI label May 3, 2016
@gmacdougall
Copy link
Member

Closing due to staleness

@tvdeyen tvdeyen self-assigned this Oct 5, 2017
tvdeyen added a commit to tvdeyen/solidus that referenced this issue Oct 5, 2017
Currently the page title and action buttons are scrollable with the rest of the page content.
Placing these items in a sticky header so that the user can always see what page they’re on
and have easy access to functions like adding new items to lists.

Closes solidusio#630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants