Improve reimbursement emails #1139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was not improving ReturnItem public api but just adding another layer that seemed too tied to the specific reimbursement email usage.
|
What about to also adding a preference for Reimbursement Mailer class, similar to Spree::CartonMailer ? |
| subject = (resend ? "[#{Spree.t(:resend).upcase}] " : '') | ||
| subject += "#{store.name} #{Spree.t('reimbursement_mailer.reimbursement_email.subject')} ##{@reimbursement.order.number}" | ||
| mail(to: @reimbursement.order.email, from: from_address(store), subject: subject) | ||
| end |
There was a problem hiding this comment.
Can you PR this in a separate PR that just fixes the indentation? I'm good with the change, just don't want to mix it up with some of the other stuff in this PR.
|
I would like this to be split up into one PR for fixing indentation, one for adding the HTML view and preview, and one for changing the Text version of the E-Mail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some improvements to the reimbursement email:
spree_sample:loadtask and attached to one order previously created.I'm open to squash commits or discuss any change or improvement.