Add reimbursement email preview #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
changed the title
|
👍 |
|
👍 Thank you. Having the sample as well is very helpful |
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Jan 29, 2020
The current code is not creating a valid reimbursement since it's created when the associated order is still not in the riht state (paid and shipped). The amount of the reimboursement was also wrong, since the return item created had an exchange variant associated, making the total of the calculated reimboursement 0. This was mainly used to allow seeing the reimboursement email in the preview (with solidusio#1146), and it was working fine for that purpose but it is creating an inconsistent order in the backend running samples. Retruns are already complex and messed up, we need to avoid showing wrong examples of code and order states to users.
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Jan 29, 2020
The current code is not creating a valid reimbursement since it's created when the associated order is still not in the riht state (paid and shipped). The amount of the reimbursement was also wrong, since the return item created had an exchange variant associated, making the total of the calculated reimboursement 0. This was mainly used to allow seeing the reimbursement email in the preview (with solidusio#1146), and it was working fine for that purpose but it is creating an inconsistent order in the backend running samples. Retruns are already complex and messed up, we need to avoid showing wrong examples of code and order states to users.
5 tasks
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Feb 1, 2020
The current code is not creating a valid reimbursement since it's created when the associated order is still not in the riht state (paid and shipped). The amount of the reimbursement was also wrong, since the return item created had an exchange variant associated, making the total of the calculated reimboursement 0. This was mainly used to allow seeing the reimbursement email in the preview (with solidusio#1146), and it was working fine for that purpose but it is creating an inconsistent order in the backend running samples. Retruns are already complex and messed up, we need to avoid showing wrong examples of code and order states to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows testing emails like other ones with the rails preview. To watch and work with this preview a real reimbursement (persisted in the database) is needed so it adds a reimbursement sample that is loaded with the spree_sample:load task and attached to one order previously created.