Declare test dependencies explicitly in gemspecs #2359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't necessary when running through the `rspec` command, but is necessary when running files manually (ruby -Ispec spec/foo_spec.rb).
Previously we lumped all spec-related dependencies in the same place, but each project has slightly different requirements. This moves the declarations from a top-level Gemfile (well, file required from Gemfile) to individual projects' gemspecs. This adds explicitness (good) at the expense of repetition (bad) and makes the spec suites faster (good).
We aren't going to be running in dev mode from within the Solidus project itself, so we don't need listen for code reloading.
It will be required when running the rubocop executable.
jhawthorn
force-pushed
the
remove_common_dependencies
branch
from
d1bcd10 to
a93c9ae
Compare
|
I'm agree to move testing dependencies from I was thinking in one file like An another like |
ccarruitero
reviewed
Nov 12, 2017
| @@ -1 +1,3 @@ | |||
| Rails.application.config.assets.precompile << 'solidus_core_manifest.js' | |||
| if Rails.application.config.respond_to?(:assets) | |||
ccarruitero
reviewed
Nov 12, 2017
| @@ -73,8 +73,10 @@ class Application < ::Rails::Application | |||
|
|
|||
| config.action_controller.include_all_helpers = false | |||
|
|
|||
| config.assets.paths << File.expand_path('../dummy_app/assets/javascripts', __FILE__) | |||
| config.assets.paths << File.expand_path('../dummy_app/assets/stylesheets', __FILE__) | |||
| if config.respond_to?(:assets) | |||
There was a problem hiding this comment.
same as comment above
gmacdougall
approved these changes
Nov 23, 2017
|
Closing in favour of #2407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on #2358, which is split out for visibility.
This moves our spec dependencies out of
common_spree_dependencies.rband into the individual gemspecs for each project. This adds explicitness (good) at the expense of repetition (bad) and makes thespec suites faster (good).