Declare test dependencies explicitly in gemspecs

api/solidus_api.gemspec

@@ -24,4 +24,14 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'responders'
   gem.add_dependency 'jbuilder', '~> 2.6'
   gem.add_dependency 'kaminari', '>= 0.17', '< 2.0'
+
+  gem.add_development_dependency 'timecop'
+  gem.add_development_dependency 'database_cleaner', '~> 1.3'
+  gem.add_development_dependency 'factory_bot', '~> 4.8'
+  gem.add_development_dependency 'rails-controller-testing'
+  gem.add_development_dependency 'rspec-activemodel-mocks', '~> 1.0.2'
+  gem.add_development_dependency 'rspec-rails', '~> 3.6.0'
+  gem.add_development_dependency 'rspec_junit_formatter'
+  gem.add_development_dependency 'simplecov'
+  gem.add_development_dependency 'with_model'
 end

api/spec/requests/spree/api/shipments_controller_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'timecop'
 
 describe Spree::Api::ShipmentsController, type: :request do
   let!(:shipment) { create(:shipment, inventory_units: [build(:inventory_unit, shipment: nil)]) }

api/spec/spec_helper.rb

@@ -18,12 +18,17 @@
 require 'spree/testing_support/dummy_app'
 DummyApp::Migrations.auto_migrate
 
+require 'rails-controller-testing'
 require 'rspec/rails'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
 Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each { |f| require f }
 
+require 'with_model'
+require 'database_cleaner'
+require 'rspec-activemodel-mocks'
+
 require 'spree/testing_support/factories'
 require 'spree/testing_support/preferences'
 require 'spree/testing_support/authorization_helpers'

backend/solidus_backend.gemspec

@@ -34,4 +34,16 @@ Gem::Specification.new do |s|
 
   s.add_dependency 'handlebars_assets', '~> 0.23'
   s.add_dependency 'autoprefixer-rails', '~> 7.1'
+
+  s.add_development_dependency 'capybara', '~> 2.15'
+  s.add_development_dependency 'capybara-screenshot', '>= 1.0.18'
+  s.add_development_dependency 'database_cleaner', '~> 1.3'
+  s.add_development_dependency 'factory_bot', '~> 4.8'
+  s.add_development_dependency 'rails-controller-testing'
+  s.add_development_dependency 'rspec-activemodel-mocks', '~> 1.0.2'
+  s.add_development_dependency 'rspec-rails', '~> 3.6.0'
+  s.add_development_dependency 'rspec_junit_formatter'
+  s.add_development_dependency 'selenium-webdriver'
+  s.add_development_dependency 'simplecov'
+  s.add_development_dependency 'with_model'
 end

backend/spec/spec_helper.rb

@@ -29,6 +29,7 @@
 
 require 'database_cleaner'
 require 'with_model'
+require 'rspec-activemodel-mocks'
 
 require 'spree/testing_support/authorization_helpers'
 require 'spree/testing_support/factories'

common_spree_dependencies.rb

@@ -15,30 +15,9 @@
   gem 'activerecord-jdbcsqlite3-adapter'
 end
 
-gem 'coffee-rails'
-gem 'sass-rails'
-
-group :test do
-  gem 'capybara', '~> 2.15'
-  gem 'capybara-screenshot', '>= 1.0.18'
-  gem 'database_cleaner', '~> 1.3'
-  gem 'factory_bot_rails', '~> 4.8'
-  gem 'launchy'
-  gem 'rspec-activemodel-mocks', '~>1.0.2'
-  gem 'rspec-rails', '~> 3.6.0'
-  gem 'simplecov'
-  gem 'poltergeist', '~> 1.9'
-  gem 'timecop'
-  gem 'with_model'
-  gem 'rspec_junit_formatter'
-  gem 'rails-controller-testing'
-  gem 'selenium-webdriver'
-end
-
 group :test, :development do
-  gem 'rubocop'
+  gem 'rubocop', require: false
   gem 'pry'
-  gem 'listen', '~> 3.1.5'
 
   platforms :mri do
     gem 'byebug'

core/config/initializers/assets.rb

@@ -1 +1,3 @@
-Rails.application.config.assets.precompile << 'solidus_core_manifest.js'
+if Rails.application.config.respond_to?(:assets)
+  Rails.application.config.assets.precompile << 'solidus_core_manifest.js'
+end

core/lib/spree/testing_support/dummy_app.rb

@@ -73,8 +73,10 @@ class Application < ::Rails::Application
 
     config.action_controller.include_all_helpers = false
 
-    config.assets.paths << File.expand_path('../dummy_app/assets/javascripts', __FILE__)
-    config.assets.paths << File.expand_path('../dummy_app/assets/stylesheets', __FILE__)
+    if config.respond_to?(:assets)
+      config.assets.paths << File.expand_path('../dummy_app/assets/javascripts', __FILE__)
+      config.assets.paths << File.expand_path('../dummy_app/assets/stylesheets', __FILE__)
+    end
 
     config.paths["config/database"] = File.expand_path('../dummy_app/database.yml', __FILE__)
     config.paths['app/views'] = File.expand_path('../dummy_app/views', __FILE__)

core/lib/spree/testing_support/dummy_app/rake_tasks.rb

@@ -40,6 +40,7 @@
   rescue LoadError
   end
 
+  require 'rails/command'
   require 'rails/commands/console/console_command'
   Rails::Console.new(Rails.application, sandbox: true, environment: "test").start
 end

core/solidus_core.gemspec

@@ -39,4 +39,13 @@ Gem::Specification.new do |s|
   s.add_dependency 'ransack', '~> 1.8'
   s.add_dependency 'state_machines-activerecord', '~> 0.4'
   s.add_dependency 'stringex', '~> 1.5.1'
+
+  s.add_development_dependency 'database_cleaner', '~> 1.3'
+  s.add_development_dependency 'factory_bot', '~> 4.8'
+  s.add_development_dependency 'rspec-activemodel-mocks', '~>1.0.2'
+  s.add_development_dependency 'rspec-rails', '~> 3.6.0'
+  s.add_development_dependency 'rspec_junit_formatter'
+  s.add_development_dependency 'simplecov'
+  s.add_development_dependency 'timecop'
+  s.add_development_dependency 'with_model'
 end

core/spec/spec_helper.rb

@@ -12,6 +12,8 @@
   end
 end
 
+require 'rspec/core'
+
 require 'spree/testing_support/preferences'
 require 'spree/config'
 require 'with_model'

frontend/solidus_frontend.gemspec

@@ -31,5 +31,15 @@ Gem::Specification.new do |s|
   s.add_dependency 'truncate_html', '~> 0.9', '>= 0.9.2'
   s.add_dependency 'kaminari', '>= 0.17', '< 2.0'
 
+  s.add_development_dependency 'capybara', '~> 2.15'
   s.add_development_dependency 'capybara-accessible'
+  s.add_development_dependency 'capybara-screenshot', '>= 1.0.18'
+  s.add_development_dependency 'database_cleaner', '~> 1.3'
+  s.add_development_dependency 'factory_bot', '~> 4.8'
+  s.add_development_dependency 'poltergeist', '~> 1.9'
+  s.add_development_dependency 'rails-controller-testing'
+  s.add_development_dependency 'rspec-activemodel-mocks', '~> 1.0.2'
+  s.add_development_dependency 'rspec-rails', '~> 3.6.0'
+  s.add_development_dependency 'rspec_junit_formatter'
+  s.add_development_dependency 'simplecov'
 end

frontend/spec/spec_helper.rb

@@ -20,13 +20,15 @@
 require 'spree/testing_support/dummy_app'
 DummyApp::Migrations.auto_migrate
 
+require 'rails-controller-testing'
 require 'rspec/rails'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 require 'database_cleaner'
+require 'rspec-activemodel-mocks'
 
 require 'spree/testing_support/authorization_helpers'
 require 'spree/testing_support/capybara_ext'

sample/solidus_sample.gemspec

@@ -21,4 +21,9 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = '>= 1.8.23'
 
   s.add_dependency 'solidus_core', s.version
+
+  s.add_development_dependency 'database_cleaner', '~> 1.3'
+  s.add_development_dependency 'rspec-rails', '~> 3.6.0'
+  s.add_development_dependency 'rspec_junit_formatter'
+  s.add_development_dependency 'simplecov'
 end

sample/spec/spec_helper.rb

@@ -9,6 +9,8 @@
 
 require 'rspec/rails'
 
+require 'database_cleaner'
+
 RSpec.configure do |config|
   config.color = true
   config.infer_spec_type_from_file_location!