Fix flaky specs around admin credit card filling #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/flaky-admin-card
branch
from
71f66c0 to
6502f61
Compare
This was available to frontend only but we also need it in backend.
These input are controlled by a js plugin (payment.js) that messes up with Capybara and gives us a lot of flaky specs. By using this hacky solution we are sure input are filled correctly, see also solidusio#2911.
We have this helper defined in this file but it was not always used. The name on card filling has been also delegated to the helper method.
Credit card number is always the same, unless we want to test an edge case, which is still possible.
to support when it's not called with a Javascript driver. Now it raises an exception while its purpose it's not needed without the Javascript enabled, since the js plugin that does not interact well with Capybara is not active.
It's not explicitely needed but a lot of js runs in those pages and it's better to test it in a more realistic way.
At the moment, after the input is filled with value=, the change event is not fired. If we had change listeners on that input they will not be executed. For example we have a .ccType hidden field that is filled with the type of the card added and this did remain empty since the backbone view that was responsible to update it after the card number was added did not get any trigger.
kennyadsl
force-pushed
the
kennyadsl/flaky-admin-card
branch
from
6502f61 to
841ba45
Compare
4 tasks
tvdeyen
approved these changes
Apr 6, 2019
4 tasks
jacobherrington
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are having some other flaky specs around credit card filling with JS enabled, very similar with what we faced on the frontend side with #2911.
Here's an example of failure on the CI:
This PR uses the
fill_in_with_forcehelper that we introduced in the frontend, also in the backend hopefully making disappear these failures.Checklist: