Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guides and add mailer customization guide #3403

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Update guides and add mailer customization guide #3403

merged 1 commit into from
Oct 25, 2019

Conversation

michaelmichael
Copy link
Contributor

Description

I updated some of the language in the customization guides. My goal was to make sentences shorter and hopefully easier to understand.

I also wrote a guide on customizing mailers in Solidus and added it in.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

spaghetticode
spaghetticode approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelmichael thank you for the extensive improvements and additions 👍

tvdeyen
tvdeyen approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Thanks 👏

@tvdeyen tvdeyen merged commit d80c4a5 into solidusio:master Oct 25, 2019
@kennyadsl kennyadsl mentioned this pull request Oct 31, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmichael @tvdeyen @spaghetticode