-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several Guides improvements #3418
Several Guides improvements #3418
Conversation
to reflect the TOC in the Overview page.
to unifor the style with the other guides markdown files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor changes for grammar, but thanks for reviewing my addition to the guides. I learned something new about how to customize mailers! 👍
guides/source/developers/customizations/customizing-mailers.html.md
Outdated
Show resolved
Hide resolved
guides/source/developers/customizations/customizing-mailers.html.md
Outdated
Show resolved
Hide resolved
guides/source/developers/customizations/customizing-mailers.html.md
Outdated
Show resolved
Hide resolved
This is something that we introduced recently and we should propose this method as the main one in guides.
1c227cd
to
f730339
Compare
@michaelmichael fixed all your suggestions, thanks a lot for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work and thanks @kennyadsl 👏
Description
This PR fixes some small issues we introduced with #3403 and fixes #3413.
cc/ @michaelmichael if you have time, your review is appreciated, thanks! 🙂
Checklist: