Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Guides improvements #3418

Merged
merged 4 commits into from
Nov 7, 2019

Conversation

kennyadsl
Copy link
Member

Description

This PR fixes some small issues we introduced with #3403 and fixes #3413.

cc/ @michaelmichael if you have time, your review is appreciated, thanks! 🙂

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)

to reflect the TOC in the Overview page.
to unifor the style with the other guides markdown files
@kennyadsl kennyadsl self-assigned this Oct 31, 2019
Copy link
Contributor

@michaelmichael michaelmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor changes for grammar, but thanks for reviewing my addition to the guides. I learned something new about how to customize mailers! 👍

This is something that we introduced recently and we should
propose this method as the main one in guides.
@kennyadsl kennyadsl force-pushed the kennyadsl/several-guides-fixes branch from 1c227cd to f730339 Compare November 4, 2019 15:10
@kennyadsl
Copy link
Member Author

@michaelmichael fixed all your suggestions, thanks a lot for the review!

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work and thanks @kennyadsl 👏

@kennyadsl kennyadsl merged commit 99e2cf7 into solidusio:master Nov 7, 2019
@kennyadsl kennyadsl deleted the kennyadsl/several-guides-fixes branch November 7, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs TOC: I think the order is messed up
4 participants