Add order_recalculated event #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetticode
force-pushed
the
spaghetticode/add-events
branch
3 times, most recently
from
e079812 to
869e71c
Compare
spaghetticode
force-pushed
the
spaghetticode/add-events
branch
from
869e71c to
d5a4358
Compare
spaghetticode
force-pushed
the
spaghetticode/add-events
branch
from
d5a4358 to
0894a1f
Compare
aldesantis
requested changes
Apr 19, 2020
There was a problem hiding this comment.
@spaghetticode thanks! It's great to see more events in the codebase. I left a couple of small comments, and the rest looks good.
spaghetticode
force-pushed
the
spaghetticode/add-events
branch
from
0894a1f to
1335dd4
Compare
aldesantis
approved these changes
Apr 21, 2020
|
@spaghetticode one thing that just came to mind: how about adding a test for the new event? |
|
@aldesantis sure 👍 |
The event is fired when the order recalculation process is completed, just before saving the order. This allows us also to deprecate the use of order's `update_hooks`.
This instance method is called in `Order#finalize!` and in `OrderUpdater#update`. Those methods now spawn the events `order_recalculated` and `order_finalized`, so when removing an existing hook, one must subscribe their hook code to both those events. Explicit calls to `OrderUpdater#run_hooks` can be replaced with `Spree::Event.fire :order_recalculated`.
As the method is deprecated, we should limit calling it to only when strictly necessary, ie when there's some actual hook to be executed.
spaghetticode
force-pushed
the
spaghetticode/add-events
branch
from
1335dd4 to
c3a1283
Compare
|
@aldesantis test added. When you confirm it looks good to you I'll merge this PR. |
aldesantis
approved these changes
May 8, 2020
|
@spaghetticode looks good to me, feel free to merge! |
cpfergus1
added a commit
to cpfergus1/solidus_klarna_payments
that referenced
this pull request
Jun 23, 2021
Please see PR #[3553](solidusio/solidus#3553) for more information concerning this change.
cpfergus1
added a commit
to cpfergus1/solidus_klarna_payments
that referenced
this pull request
Jun 24, 2021
Please see PR #[3553](solidusio/solidus#3553) for more information concerning this change.
cpfergus1
added a commit
to cpfergus1/solidus_klarna_payments
that referenced
this pull request
Jul 6, 2021
Please see PR #[3553](solidusio/solidus#3553) for more information concerning this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new event
order_recalculated, also deprecating the use of order update hooks and the public methodOrderUpdater#run_hooks. A conditional check has been added before running#run_hooksin order to avoid tons of not-needed deprecation messages.Checklist: