Test sf4 #4742
Test sf4 #4742
Conversation
greg0ire
force-pushed
the
test_sf4
branch
3 times, most recently
from
89d6f33 to
7924b3a
Compare
|
This can be merged now, but I need to fix a test on SonataCore for the sf3.4 build to be green. |
See sonata-project/SonataCoreBundle#457 @soullivaneuh ideally, merge that one before, then release, and let me bump the version constraint in this PR. If you think this is going to be slow, then please merge it now instead. |
|
This allows testing sf4. Currently it breaks because I need to do yet another correction on the abstract widget tests case, because I got no deprecation warning regarding |
|
Could you please rebase your PR and fix merge conflicts? |
| @@ -479,14 +490,20 @@ public function testProcessAbstractAdminServiceInServiceDefinition() | |||
| ->setArguments(['', 'Sonata\AdminBundle\Tests\DependencyInjection\Post', '']) | |||
| ->setAbstract(true); | |||
|
|
|||
| $adminDefinition = new DefinitionDecorator('sonata_abstract_post_admin'); | |||
| $adminDefinition = class_exists(ChildDefinition::class) ? | |||
There was a problem hiding this comment.
This is a BC trick for SF > 3.3 SF < 3.3, please add a NEXT_MAJOR comment.
| ->setClass('Sonata\AdminBundle\Tests\DependencyInjection\MockAbstractServiceAdmin') | ||
| ->setArguments([0 => 'extra_argument_1']) | ||
| ->addTag('sonata.admin', ['group' => 'sonata_post_one_group', 'manager_type' => 'orm']); | ||
|
|
||
| $adminTwoDefinition = new DefinitionDecorator('sonata_abstract_post_admin'); | ||
| $adminTwoDefinition = class_exists(ChildDefinition::class) ? |
| $definitionOrReference = $articleRouteBuilderMethodCall[1][0]; | ||
| if ($definitionOrReference instanceof Definition) { | ||
| $this->assertSame( | ||
| 'Sonata\DoctrinePHPCRAdminBundle\Route\PathInfoBuilderSlashes', |
This fixes a deprecation triggered while running tests.
The compiler pass that injects default dependencies needs it.
Definitions no longer know their service id in Symfony 4
This will allow running some tests on them.
It comes with a fix that will make some deprecations go away.
|
No travis test with SF 4.0 beta? |
|
@OskarStark it's called dev-master ;) |
Do not merge, this is a proof PR.the dev-kit PR has been merged, so this should be mergeable too.