This repository has been archived by the owner on Sep 30, 2021. It is now read-only.
Sf 3.4 compat #457
Merged
Sf 3.4 compat #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
previously approved these changes
Nov 4, 2017
greg0ire
force-pushed
the
sf_3.4_compat
branch
2 times, most recently
from
9183b09 to
c692b95
Compare
soullivaneuh
suggested changes
Nov 4, 2017
Test/AbstractWidgetTestCase.php
Outdated
| @@ -88,6 +78,11 @@ protected function setUp() | |||
| $this->extension->initRuntime($environment); | |||
| } | |||
|
|
|||
| public function getRenderer() | |||
greg0ire
force-pushed
the
sf_3.4_compat
branch
from
c692b95 to
94f03f6
Compare
soullivaneuh
previously approved these changes
Nov 4, 2017
core23
reviewed
Nov 4, 2017
Test/AbstractWidgetTestCase.php
Outdated
| @@ -89,6 +80,14 @@ protected function setUp() | |||
| } | |||
|
|
|||
| /** | |||
| * @return TwigRendererInterface | |||
| */ | |||
| public function getRenderer() | |||
This breaks with Symfony 3.4, but luckily, there is a very simple implementation of Twig_RuntimeLoaderInterface, let's try it! Implies a minor Twig version bump.
greg0ire
force-pushed
the
sf_3.4_compat
branch
from
94f03f6 to
05b20e0
Compare
core23
approved these changes
Nov 4, 2017
soullivaneuh
suggested changes
Nov 4, 2017
| ->method('load') | ||
| ->with($this->equalTo('Symfony\Bridge\Twig\Form\TwigRenderer')) | ||
| ->will($this->returnValue($this->renderer)); | ||
| $runtimeLoader = new \Twig_FactoryRuntimeLoader([ |
There was a problem hiding this comment.
You can use this: https://github.com/twigphp/Twig/blob/1.x/src/RuntimeLoader/FactoryRuntimeLoader.php
Twig 1.34 is required.
soullivaneuh
approved these changes
Nov 4, 2017
| ->method('load') | ||
| ->with($this->equalTo('Symfony\Bridge\Twig\Form\TwigRenderer')) | ||
| ->will($this->returnValue($this->renderer)); | ||
| $runtimeLoader = new \Twig_FactoryRuntimeLoader([ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this does not break BC.
Changelog
Subject
This fixes the 3.4 build.