feat(core): changes condition script for passed by and coming in clauses #14
Conversation
…is already selected GH-8
maninder-pal-singh
changed the title
|
==== Karma Test Coverage ==== |
…rigger has anyValue GH-9
|
==== Karma Test Coverage ==== |
|
==== Karma Test Coverage ==== |
|
==== Karma Test Coverage ==== |
|
==== Karma Test Coverage ==== |
|
==== Karma Test Coverage ==== |
| @@ -346,6 +366,30 @@ export class BuilderComponent<E> implements OnInit, OnChanges { | |||
| value: AllowedValues | AllowedValuesMap, | |||
| select = false, | |||
| ) { | |||
| if ( | |||
| (input.getIdentifier() === 'ValueTypeInput' || | |||
There was a problem hiding this comment.
should ideally not have any reference to input type here in this component
| if (isValid) { | ||
| for (const node of nodes) { | ||
| switch (node.node.getIdentifier()) { | ||
| case EventTypes.OnChangeEvent: |
There was a problem hiding this comment.
as mentioned, the builder component should not have any code specific to event types
| (!!this.actionGroups[0].children.length || | ||
| !!this.elseActionGroups[0].children.length); | ||
| if (isValid) { | ||
| for (const node of nodes) { |
There was a problem hiding this comment.
for validation, we can use a separate service that gets the current state of diagram and just returns true or false and use that here, and this should be based on the default inputs provided. Anyone using the library should be able to replace it to write there own logic according to there own custom events/actions/inputs
| @@ -94,6 +94,12 @@ export abstract class WorkflowPrompt { | |||
| const dateTime = `${this.onDateSelect(date)} ${hours}:${min}`; | |||
| return moment(dateTime.toString(), 'DD-MM-YYYY hh:mm').format(); | |||
| case InputTypes.Email: | |||
| (value as AllowedValuesMap).body = ( | |||
| (value as AllowedValuesMap).body as string | |||
| ).replace(/"/g, '\\"'); | |||
There was a problem hiding this comment.
leave a comment for why
* fix(core): fix valuetype any change fix valuetype any change GH-9-valueAny * fix(core): saurabh sinha json changes saurabh sinha json changes GH-9-valueAny --------- Co-authored-by: Abhinav Verma <[email protected]>
* feat(core): add timeinterval for the interval trigger in workflow * refactor(core): add changes
Description
fixes status column not being selected when priority column
fixes UI discrepancy when value width is too large
fixes incorrect condition for is past today
changes condition script for passed by and coming in clauses
Fixes # (issue)
GH-9
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: