-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] rename containment
to contained_by
#199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 13 13
Lines 1974 1974
Branches 52 52
=======================================
Hits 1702 1702
Misses 262 262
Partials 10 10
Continue to review full report at Codecov.
|
ctb
changed the title
[WIP] fixes needed for spacegraphcats
[MRG] fixes needed for spacegraphcats
May 21, 2017
ctb
changed the title
[MRG] fixes needed for spacegraphcats
[MRG] rename May 23, 2017
containment
to contained_by
Ready for review & merge! |
luizirber
approved these changes
May 24, 2017
Do you want to keep the |
yes, for a bit - thank you.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that
containment
was confusing, so we renamed it tocontained_by
.make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?