Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update PR: deduce ksize from query #224

Merged
merged 7 commits into from
May 17, 2017
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented May 16, 2017

Updates #119 so tests pass.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author

ctb commented May 16, 2017

Note, includes #217 which will be merged as soon as CI passes.

@ctb ctb mentioned this pull request May 16, 2017
9 tasks
@codecov-io
Copy link

codecov-io commented May 16, 2017

Codecov Report

Merging #224 into master will decrease coverage by 0.13%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   85.78%   85.64%   -0.14%     
==========================================
  Files          13       13              
  Lines        1942     1951       +9     
  Branches       52       52              
==========================================
+ Hits         1666     1671       +5     
- Misses        266      270       +4     
  Partials       10       10
Impacted Files Coverage Δ
sourmash_lib/sourmash_args.py 93.42% <100%> (+0.17%) ⬆️
sourmash_lib/commands.py 90.07% <71.42%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705afe3...9e127f0. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented May 16, 2017

@betatim ok to merge?

@ctb ctb changed the title Update PR: deduce ksize from query [MRG] Update PR: deduce ksize from query May 17, 2017
Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants