-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Update PR: deduce ksize from query #224
Conversation
When the query only contains on k-size then use that unless user specified a particular k.
Note, includes #217 which will be merged as soon as CI passes. |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 85.78% 85.64% -0.14%
==========================================
Files 13 13
Lines 1942 1951 +9
Branches 52 52
==========================================
+ Hits 1666 1671 +5
- Misses 266 270 +4
Partials 10 10
Continue to review full report at Codecov.
|
@betatim ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Updates #119 so tests pass.
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?