This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Port command payload/view manager/metadata storage/metaclass generators #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
jira/no-ticket
improbable-prow-robot
added
size/XXL
jamiebrynes7
approved these changes
Jan 22, 2020
| var receivedRequestType = $"{command.CommandName}.ReceivedRequest"; | ||
| var receivedResponseType = $"{command.CommandName}.RawReceivedResponse"; | ||
|
|
||
| partial.Line($@" |
There was a problem hiding this comment.
Ya just didn't want to use the nice fluent API huh? Also this class can totally just be a generic base class that's not code generated.
paulbalaji
commented
Jan 22, 2020
...es/io.improbable.gdk.core/.codegen/Source/Generators/Core/CommandMetaDataStorageGenerator.cs
Outdated
Show resolved
Hide resolved
added 2 commits
January 22, 2020 12:23
zeroZshadow
approved these changes
Jan 22, 2020
added 5 commits
January 22, 2020 15:14
…or-unity into feature/port-core-part-4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ported
Tests
see generated code
Documentation
will add in the final core port PR
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.