Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Port command payload/view manager/metadata storage/metaclass generators #1252

Merged
merged 11 commits into from
Jan 22, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
self review
Paul Balaji committed Jan 22, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 0e110ed3330faf49eaa92148acdebfc6fd0b5f8e
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@ public static string Generate(UnityComponentDetails componentDetails, string qua
{
Logger.Trace($"Generating {qualifiedNamespace}.{componentDetails.ComponentName}.{command.CommandName}CommandMetaDataStorage class.");

var receivedRequestType = $"{command.CommandName}.ReceivedRequest";
var receivedResponseType = $"{command.CommandName}.RawReceivedResponse";

partial.Line($@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya just didn't want to use the nice fluent API huh? Also this class can totally just be a generic base class that's not code generated.

public class {command.CommandName}CommandMetaDataStorage : ICommandMetaDataStorage, ICommandPayloadStorage<{command.FqnRequestType}>
{{