chore(civil3d): add comment for featureline display values #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzhankoral
approved these changes
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #509 +/- ##
=======================================
Coverage 15.05% 15.05%
=======================================
Files 239 239
Lines 4703 4703
Branches 578 578
=======================================
Hits 708 708
Misses 3964 3964
Partials 31 31 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds a simple POC comment to featureline display value conversion.
Featurelines are 2.5d curves: they can have line or arc segments, and different elevations at each vertex.
There is no native way to retrieve the full 3d accurate representation of a featureline, so currently we are sending them as 3d polylines with line segments only.
Adding comment for context in case future bug reports happen due to polyline representation of polycurve featurelines.