Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(civil3d): add comment for featureline display values #509

Merged
merged 2 commits into from
Jan 21, 2025
Merged

chore(civil3d): add comment for featureline display values #509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d927f
Update DisplayValueExtractor.cs
clairekuang Jan 21, 2025
30781e2
Merge branch 'dev' into claire/cnx-989-survey-figures-with-arc-parts
clairekuang Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Converters/Civil3d/Speckle.Converters.Civil3dShared/Helpers/DisplayValueExtractor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ public IEnumerable<Base> GetDisplayValue(CDB.Entity entity)
{
switch (entity)
{
// POC: we are sending featurelines as approximated polylines because they are 2.5d curves:
// they can have line or arc segments, and each vertex can have different elevations.
// there is no native type that can capture the full 3d representation of these curves.
// if this becomes essential, can explore a hack where each point is converted to 2d, and separate line/arc segments are calculated, and then their points readjusted with 3d z values
// SurveyFigures inherit from featureline
case CDB.FeatureLine featureline:
SOG.Polyline featurelinePolyline = _pointCollectionConverter.Convert(
featureline.GetPoints(Autodesk.Civil.FeatureLinePointType.PIPoint)
Expand Down
Loading