-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.1.0rc #1028
v1.1.0rc #1028
Conversation
If my understanding is correct, this PR collects several smaller PRs into a single big one. IMHO it's much more likely that small PRs get merged. So I think this can be closed in favor of the existing small chunks. |
@corneliusweig, in the context of the last 15-20 months, #840 proves the opposite. Precisely, those smaller chunks need to be combined and conflicts need to be resolved. Here, all conflicts are resolved already. |
🤔 Well #840 combines several trivial patches and touches ~100 lines. This one touches >1k lines and is not as easily reviewable. That's why I suspect that it is unlikely to ever get merged. But I see that resolving all conflicts has some value to it. |
Sinve v1.0.0 was released a few days ago (🎉 🎉 🎉), this PR is now renamed to v1.1.0rc. It is also rebased on top of master. |
62d881d
to
f60e06e
Compare
b12cd46
to
3faaf7f
Compare
b1f55d6
to
d95cee9
Compare
This removes "Lesser" from the GPL-2.0 header template, since that header is meant to be referring to GPL-2.0 and not LGPL-2.0. Signed-off-by: Steve Winslow <[email protected]>
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
As done in #840, this PR gathers multiple pending PRs, in an effort to help the maintainers get some work out of their tasklist:
Close #754 (@0robustus1)Close #774 (@Brcrwilliams)Close #841
Close #1044Close #880 (@swinslow)
Close #896 (@nelz9999)
Close #929 (@desponda)Close #936 (@rhcarvalho)
Close #937 (@rhcarvalho)Close #949
Close #968Close #1009 (@nickolashkraus)
Close #1012