Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint, and fix linting issues #876

Closed
wants to merge 21 commits into from
Closed

Add golangci-lint, and fix linting issues #876

wants to merge 21 commits into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Jun 7, 2019 •
edited
Loading

Close #774
Close #853
Close #933

In this PR, golangci-lint is added to Travis CI. Then, multiple linting issues are fixed: errors are handled, unused variables/functions are removed, unnecessary types are removed, frequently used strings are defined as constants, etc.

As a result of using io.StringWriter and os.UserHomeDir, merging this PR implies dropping support for golang 1.10.x and 1.11.x.

This was referenced Jul 14, 2019
Closed
Merged
@umarcor umarcor mentioned this pull request Aug 23, 2019
Closed
@andig andig mentioned this pull request Aug 23, 2019
Closed
@umarcor umarcor force-pushed the golangci-lint branch 2 times, most recently from 36f1bcb to 102ec4c Compare September 5, 2019 15:09
@umarcor umarcor mentioned this pull request Sep 16, 2019
Closed
@umarcor umarcor force-pushed the golangci-lint branch 2 times, most recently from 627305e to c9c0123 Compare September 17, 2019 16:28
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
e118d75 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
eb2182c 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
c193de8 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
e63a44d 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
4f8dddc 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
d8b5514 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
5684540 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
e540266 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
@umarcor umarcor mentioned this pull request Oct 9, 2019
Merged
@umarcor umarcor force-pushed the golangci-lint branch 3 times, most recently from 06836a5 to 48f9c90 Compare October 9, 2019 23:37
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 14, 2019
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
da4dc39 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
@umarcor umarcor mentioned this pull request Oct 20, 2019
Merged
@umarcor
Copy link
Contributor Author

umarcor commented Jan 4, 2020 •
edited
Loading

@jharshman, since go 1.10.x and 1.11.x are officially deprecated (see https://golang.org/doc/devel/release.html and https://endoflife.date/go), I believe we should consider this PR for inclusion in v1.0.0. This PR does not include any functional modification; it is all about using up-to-date linters and fixing outdated/broken/unused code.

@umarcor umarcor force-pushed the golangci-lint branch 2 times, most recently from 9c0851f to 4ab14c0 Compare January 4, 2020 18:29
umarcor added 3 commits January 6, 2020 19:25
@umarcor
fix: add cobra/cmd/testproject to gitignore
31f8371
@umarcor
fix gosec G204
2d75916
@umarcor
ci: add go 1.13.x
4fe7dea 
* circleci: export GO111MODULE=on, add 1.13.x, remove 1.11.x
* travis: add go 1.13.x
umarcor added a commit to umarcor/cobra that referenced this pull request Jan 6, 2020
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
cac49a2 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
223cbc8 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
c23aaab 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Feb 3, 2020
@umarcor
deprecate <1.12.x, use golangci-lint (spf13#876)
3fab722 
* deprecate go 1.10.x and 1.11.x
* use golangci-lint in Travis CI
* fix linting issues accordingly
@umarcor umarcor mentioned this pull request Feb 3, 2020
Closed
@jharshman
Copy link
Collaborator

closed by #976

@jharshman jharshman closed this Feb 20, 2020
@umarcor
Copy link
Contributor Author

umarcor commented Feb 20, 2020 •
edited
Loading

@jharshman, this issue is about adding golangci-lint to have a more complete set of linters. Then, the source code is modified to fix all the issues/bugs that are currently ignored due to a lack of linting tools. Deprecating 1.10.x and 1.11.x is an effect of enhancing the code to use modern features; not the purpose of the issue.

Since #976 does not enhance nor fix linting, I'd like to have this issue reopened.

@umarcor umarcor changed the title Add golangci-lint, deprecate go 1.10.x and 1.11.x, cleanup/fixes Add golangci-lint, and fix linting issues Feb 20, 2020
umarcor added a commit to umarcor/cobra that referenced this pull request Feb 20, 2020
@umarcor
use golangci-lint (spf13#876)
9922ec4 
* use golangci-lint in Travis CI
* fix linting issues accordingly
@umarcor umarcor mentioned this pull request Feb 26, 2020
Merged
umarcor added a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
@umarcor
use golangci-lint (spf13#876)
bab9543 
* use golangci-lint in Travis CI
* fix linting issues accordingly
umarcor added a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
41205a0
umarcor added a commit to umarcor/cobra that referenced this pull request Apr 13, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
20ef273
umarcor added a commit to umarcor/cobra that referenced this pull request May 11, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
22fa5fe
umarcor added a commit to umarcor/cobra that referenced this pull request May 11, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
c4ed186
umarcor added a commit to umarcor/cobra that referenced this pull request May 11, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
0379cfe
umarcor added a commit to umarcor/cobra that referenced this pull request Jul 4, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
607eb30
umarcor added a commit to umarcor/cobra that referenced this pull request Jul 11, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
f1584cb
umarcor added a commit to umarcor/cobra that referenced this pull request Jul 13, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
225b067
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
use golangci-lint (spf13#876) (spf13#1044)
f19fe8c
umarcor added a commit to umarcor/cobra that referenced this pull request Sep 25, 2020
@umarcor
use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044
72c92fb 
)
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 1, 2020
@umarcor
use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044
f9ea39e 
)
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 14, 2020
@umarcor
use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044
dc9bed2 
)
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 18, 2020
@umarcor
use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044
eab7ed2 
)
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 4, 2020
@umarcor
use golangci-lint and GitHub Actions (spf13#876) (spf13#968) (spf13#1044
932b1eb 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated files are not goimports-ed
2 participants
@umarcor @jharshman