-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish an AuditEvent on logout #1836
Comments
After reconsideration this might not be a addition for Spring Boot, it uses by default basic authentication for which logout will not work. |
Logout works if there is a session (which would be the normal way of using Spring Boot with a UI). Also, I do not think this is a Boot issue. If SEC-2680 is resolved we'd pick up the events with no changes. |
If a logout event is issued you might need to add a new auditevent so that it can be logged properly. Now only But agreed that is just a minor enhancement and relies upon the solution provided by SEC-2680. |
+1 for this |
I think we should leave this to the Spring Security fix suggested in SEC-2680 |
There is no such class `ReplyQosSettings`. Closes spring-projectsgh-1836
can I make a try out on this? |
Please do @Chu3laMan. You'll probably want to take a look at |
@philwebb It's already done, don't we need to take care about handling errors during logout phase inside the same method? |
Closing in favor of PR #41278. Thanks @Chu3laMan |
Currently the actuator does a good job on sending
AuditEvent
s on login (ok/failure) authentication etc. would be nice if that could also be done for a logout. This can probably be implemented with aLogoutHandler
which gets invoked in the logout chain or anotherApplicationListener
that listens forSessionDestroyedEvent
s.Would be especially nice if a difference could be made between a regular logoff or a session timeout.
Might be related to SEC-2680.
The text was updated successfully, but these errors were encountered: