Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEC-2680: Fire an event when logout has finished #2900

Closed
spring-projects-issues opened this issue Jul 9, 2014 · 6 comments
Closed

SEC-2680: Fire an event when logout has finished #2900

spring-projects-issues opened this issue Jul 9, 2014 · 6 comments
Assignees
@rwinch
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Milestone
5.2.0

Comments

@spring-projects-issues
Copy link

Marten Deinum (Migrated from SEC-2680) said:

During login several events can be fired like for instance AuthenticationSuccessEvent and AuthenticationFailureExpiredEvent. It would be nice that on a logout (successful, session limit exceeded etc.) also an event would be fired.

This would enable to create an ApplicationListener which logs the start/end of a user session.
@spring-projects-issues spring-projects-issues added in: core An issue in spring-security-core Open type: jira An issue that was migrated from JIRA labels Feb 5, 2016
@ptahchiev
Copy link

+1 on this one.

@philwebb philwebb mentioned this issue May 13, 2016
Closed
@mdeinum mdeinum mentioned this issue May 13, 2016
Closed
1 task
@kazuki43zoo
Copy link
Contributor

This issue is same with #3307.

@okohub
Copy link
Contributor

okohub commented Mar 18, 2018

@rwinch hello, is this issue still active? are there any plans to integrate this feature?

@rwinch rwinch added type: enhancement A general enhancement and removed Open labels May 3, 2019
@okohub
Copy link
Contributor

okohub commented Aug 21, 2019

@rwinch Hello Rob, there is an active another issue about this #3307. Should I open a new PR for this enhancement? What do you think?

@rwinch rwinch mentioned this issue Aug 22, 2019
Closed
@rwinch
Copy link
Member

rwinch commented Aug 22, 2019

Thanks for pointing out the duplicate. If you are able, we'd love for a PR to be submitted.

@okohub okohub mentioned this issue Aug 23, 2019
Closed
okohub added a commit to okohub/spring-security that referenced this issue Aug 23, 2019
@okohub
Introduce LogoutSuccessEvent
6d1e68a 
LogoutSuccessEvent is a simple AbstractAuthenticationEvent implementation which indicates successful logout.

By default, LogoutConfigurer will add a new LogoutHandler called LogoutSuccessEventPublishingLogoutHandler to publish this event.

This PR will also fix ConcurrentSessionFilter's composite logoutHandler, now will get LogoutHandler instances from LogoutConfigurer for consistency.

Fixes spring-projectsgh-2900
@okohub
Copy link
Contributor

okohub commented Sep 10, 2019 •
edited
Loading

@rwinch Hello Rob, the PR is open. Do you have a time to check? May be this can be included to 5.2.0 line. thanks! :)

#7306

@rwinch rwinch closed this as completed in 034b5e9 Sep 18, 2019
@rwinch rwinch self-assigned this Sep 18, 2019
@rwinch rwinch added this to the 5.2.0 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Introduce LogoutSuccessEvent okohub/spring-security
5 participants
@rwinch @okohub @ptahchiev @kazuki43zoo @spring-projects-issues