Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make description of virtual threads and JVM exit easier to understand by removing "no-non" double-negative #39732

Closed
wilkinsona opened this issue Feb 22, 2024 · 0 comments
Closed

Make description of virtual threads and JVM exit easier to understand by removing "no-non" double-negative #39732

wilkinsona opened this issue Feb 22, 2024 · 0 comments
Assignees
@wilkinsona
Labels
type: documentation A documentation update
Milestone
3.2.4

Comments

@wilkinsona
Copy link
Member

Chatting with @snicoll, the current description of virtual threads and the impact on the JVM exiting is a little hard to understand. It currently reads as follows:

One side effect of virtual threads is that these threads are daemon threads. A JVM will exit if there are no non-daemon threads.

We think the following may be easier to understand:

One side effect of virtual threads is that they are daemon threads. A JVM will exit if all of its threads are daemon threads.
@wilkinsona wilkinsona added the type: documentation A documentation update label Feb 22, 2024
@wilkinsona wilkinsona added this to the 3.2.x milestone Feb 22, 2024
lukasdo pushed a commit to lukasdo/spring-boot that referenced this issue Feb 22, 2024
spring-projectsGH-39732 Update description of virtual threads
31dcc00
@wilkinsona wilkinsona self-assigned this Feb 23, 2024
@wilkinsona wilkinsona mentioned this issue Feb 23, 2024
Closed
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.4 Feb 23, 2024
@Netyyyy Netyyyy mentioned this issue Mar 22, 2024
Merged
ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this issue Dec 4, 2024
@ndwlocatieservices
Merged PR 68632: Update all non-major dependencies
ad302c7 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `3.2.0` -> `3.2.4` |
| [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | compile | minor | `2.17.0` -> `2.18.0` |
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | minor | `3.3.5` -> `3.4.0` |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary>

### [`v3.2.4`](https://github.com/spring-projects/spring-boot/releases/tag/v3.2.4)

[Compare Source](spring-projects/spring-boot@v3.2.3...v3.2.4)

#### ⭐ New Features

-   Add TWENTY_TWO to JavaVersion enum [#&#8203;39825](spring-projects/spring-boot#39825)

#### 🐞 Bug Fixes

-   Thread name prefix is not always set when using virtual threads [#&#8203;39958](spring-projects/spring-boot#39958)
-   spring-boot-maven-plugin doesn't work with Java 22 [#&#8203;39927](spring-projects/spring-boot#39927)
-   Resolving a BuildpackReference created from a URL-like String can fail on Windows [#&#8203;39793](spring-projects/spring-boot#39793)
-   SpringProfile arbiter fails without a Spring's environment [#&#8203;39786](spring-projects/spring-boot#39786)
-   bootStartScripts tasks should be an instance of org.gradle.api.tasks.application.CreateStartScripts rather than its superclass org.gradle.jvm.application.tasks.CreateStartScripts [#&#8203;39764](spring-projects/spring-boot#39764)
-   When using Logback, log messages appear in a single line when application name contains brackets [#&#8203;39564](spring-projects/spring-boot#39564)

#### 📔 Documentation

-   Document support for Java 22 [#&#8203;40046](spring-projects/spring-boot#40046)
-   Fix web session javadoc typo [#&#8203;39821](spring-projects/spring-boot#39821)
-   Fix typo in Custom HTTP Exchange Recording section [#&#8203;39784](spring-projects/spring-boot#39784)
-   Make description of virtual threads and JVM exit easier to understand by removing "no-non" double-negative [#&#8203;39732](spring-projects/spring-boot#39732)

#### 🔨 Dependency Upgrades

-   Upgrade to Angus Mail 2.0.3 [#&#8203;39973](spring-projects/spring-boot#39973)
-   Upgrade to Glassfish JAXB 4.0.5 [#&#8203;39975](spring-projects/spring-boot#39975)
-   Upgrade to Graph...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.2.4
Development

No branches or pull requests
1 participant
@wilkinsona