Thread name prefix is not always set when using virtual threads #39958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irtual threads. 2. Added tests for it.
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
changed the title
mhalbritter
added
type: bug
This was referenced Mar 18, 2024
mhalbritter
pushed a commit
that referenced
this pull request
Mar 18, 2024
mhalbritter
added a commit
that referenced
this pull request
Mar 18, 2024
|
I see. You guys prefer that way. Got it. |
ndwlocatieservices
added a commit
to ndwnu/nls-routing-map-matcher
that referenced
this pull request
Dec 4, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `3.2.0` -> `3.2.4` | | [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | compile | minor | `2.17.0` -> `2.18.0` | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | minor | `3.3.5` -> `3.4.0` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary> ### [`v3.2.4`](https://github.com/spring-projects/spring-boot/releases/tag/v3.2.4) [Compare Source](spring-projects/spring-boot@v3.2.3...v3.2.4) #### ⭐ New Features - Add TWENTY_TWO to JavaVersion enum [#​39825](spring-projects/spring-boot#39825) #### 🐞 Bug Fixes - Thread name prefix is not always set when using virtual threads [#​39958](spring-projects/spring-boot#39958) - spring-boot-maven-plugin doesn't work with Java 22 [#​39927](spring-projects/spring-boot#39927) - Resolving a BuildpackReference created from a URL-like String can fail on Windows [#​39793](spring-projects/spring-boot#39793) - SpringProfile arbiter fails without a Spring's environment [#​39786](spring-projects/spring-boot#39786) - bootStartScripts tasks should be an instance of org.gradle.api.tasks.application.CreateStartScripts rather than its superclass org.gradle.jvm.application.tasks.CreateStartScripts [#​39764](spring-projects/spring-boot#39764) - When using Logback, log messages appear in a single line when application name contains brackets [#​39564](spring-projects/spring-boot#39564) #### 📔 Documentation - Document support for Java 22 [#​40046](spring-projects/spring-boot#40046) - Fix web session javadoc typo [#​39821](spring-projects/spring-boot#39821) - Fix typo in Custom HTTP Exchange Recording section [#​39784](spring-projects/spring-boot#39784) - Make description of virtual threads and JVM exit easier to understand by removing "no-non" double-negative [#​39732](spring-projects/spring-boot#39732) #### 🔨 Dependency Upgrades - Upgrade to Angus Mail 2.0.3 [#​39973](spring-projects/spring-boot#39973) - Upgrade to Glassfish JAXB 4.0.5 [#​39975](spring-projects/spring-boot#39975) - Upgrade to Graph...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the thread names are missing for rabbit listener, pulsars' consumer and task executor.
This PR added the thread names for mentioned components following convention specified in other autoconfigs via RabbitAnnotationDrivenConfiguration and PulsarAutoconfiguration.
Tests are added as well to check the threads names are specified when threads are created (via java.util.concurrent.ThreadFactory#newThread) through the factory.
Request / bug ticket, #39748