Skip to content

Commit

Permalink
Improve Logging
Browse files Browse the repository at this point in the history
Closes gh-14837
  • Loading branch information
jzheaux committed Apr 17, 2024
1 parent 71a51db commit 657760a
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private RequestMatcherDelegatingAuthorizationManager(
@Override
public AuthorizationDecision check(Supplier<Authentication> authentication, HttpServletRequest request) {
if (this.logger.isTraceEnabled()) {
this.logger.trace(LogMessage.format("Authorizing %s", request));
this.logger.trace(LogMessage.format("Authorizing %s", requestLine(request)));
}
for (RequestMatcherEntry<AuthorizationManager<RequestAuthorizationContext>> mapping : this.mappings) {

Expand All @@ -76,7 +76,7 @@ public AuthorizationDecision check(Supplier<Authentication> authentication, Http
if (matchResult.isMatch()) {
AuthorizationManager<RequestAuthorizationContext> manager = mapping.getEntry();
if (this.logger.isTraceEnabled()) {
this.logger.trace(LogMessage.format("Checking authorization on %s using %s", request, manager));
this.logger.trace(LogMessage.format("Checking authorization on %s using %s", requestLine(request), manager));
}
return manager.check(authentication,
new RequestAuthorizationContext(request, matchResult.getVariables()));
Expand All @@ -86,6 +86,10 @@ public AuthorizationDecision check(Supplier<Authentication> authentication, Http
return null;
}

private static String requestLine(HttpServletRequest request) {
return request.getMethod() + " " + UrlUtils.buildRequestUrl(request);
}

/**
* Creates a builder for {@link RequestMatcherDelegatingAuthorizationManager}.
* @return the new {@link Builder} instance
Expand Down

0 comments on commit 657760a

Please sign in to comment.