Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Logging in RequestMatcherDelegatingAuthorizationManage #14837

Closed
canattofilipe opened this issue Apr 3, 2024 · 0 comments
Closed

Enhance Logging in RequestMatcherDelegatingAuthorizationManage #14837

canattofilipe opened this issue Apr 3, 2024 · 0 comments
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone

Comments

@canattofilipe
Copy link

Expected Behavior
Currently, the method RequestMatcherDelegatingAuthorizationManager.check is logging a message that doesn't provide much value.

When I enable the TRACE log level, I expect to see detailed logs that provide valuable information for troubleshooting purposes.

Current Behavior
The system is currently logging messages similar to this:
2024-04-03T14:38:42.649-03:00 TRACE 488138 --- [io-8080-exec-10] estMatcherDelegatingAuthorizationManager : Authorizing SecurityContextHolderAwareRequestWrapper[ org.springframework.security.web.savedrequest.SavedRequestAwareWrapper@5dff36af]

Logging a class that does not override the toString method merely populates the logs with uninformative content. Consider modifying this log instruction to include the URL being authorized, providing more context for troubleshooting.

@canattofilipe canattofilipe added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Apr 3, 2024
@canattofilipe canattofilipe changed the title Improve log on RequestMatcherDelegatingAuthorizationManager Enhance Logging in RequestMatcherDelegatingAuthorizationManage Apr 3, 2024
@jzheaux jzheaux self-assigned this Apr 16, 2024
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 16, 2024
@jzheaux jzheaux added this to the 5.8.13 milestone Apr 17, 2024
jzheaux added a commit that referenced this issue Apr 17, 2024
@jzheaux jzheaux moved this to Done in Spring Security Team May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
Status: Done
Development

No branches or pull requests

2 participants