Wrong information for RequestCacheAwareFilter in the Spring Security documentation. #14855
Labels
in: docs
An issue in Documentation or samples
status: ideal-for-contribution
An issue that we actively are looking for someone to help us with
type: bug
A general bug
Milestone
Comments
angel-gruevski
added
status: waiting-for-triage
|
Fair point, @angel-gruevski. Are you able to submit a PR, correcting the documentation? |
jzheaux
added
in: docs
|
Yes, I've just submitted a PR #14860 |
angel-gruevski
added a commit
to angel-gruevski/spring-security
that referenced
this issue
Apr 22, 2024
Correct Documentation Corrected a mistake in the documentation related to RequestCacheAwareFilter Closes spring-projectsgh-14855
|
Closing in favor of #14860 |
marcusdacoregio
pushed a commit
that referenced
this issue
Apr 30, 2024
…lter Corrected a mistake in the documentation for the Spring Architecture where it was mentioned that RequestCacheAwareFilter is used to save the HttpServletRequest instead of the ExceptionTranslationFilter Closes gh-14855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for Spring Security, section Servlet Architecture -> Architecture mentions the following:
"The RequestCacheAwareFilter uses the RequestCache to save the HttpServletRequest."
The statement above is incorrect, because the RequestCacheAwareFilter uses the RequestCache to get the saved HttpServletRequest after the user authenticates, while the ExceptionTranslationFilter uses the RequestCache to save the HttpServletRequest after the user requested protected resource in an unauthenticated request.
https://docs.spring.io/spring-security/reference/servlet/architecture.html#requestcacheawarefilter
The text was updated successfully, but these errors were encountered: