-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected a mistake in the documentation for the Spring Architecture #14860
Conversation
…where it was mentioned that RequestCacheAwareFilter is used to save the HttpServletRequest instead of the ExceptionTranslationFilter
@angel-gruevski Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@angel-gruevski Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @angel-gruevski! In addition to my inline feedback, will you please adjust your Git commit message to follow the following format:
Correct Documentation
Your description, if any, wrapping about every 60 characters
or so.
Closes gh-14855
That syntax helps so that, first, the associated ticket is closed automatically, and second, the Git history is easier to read.
Correct Documentation Corrected a mistake in the documentation related to RequestCacheAwareFilter Closes spring-projectsgh-14855
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the corrections
@angel-gruevski, thanks so much for the updates. Will you please do one more cleanup item for me and squash your commits? |
Thanks @angel-gruevski. This is now merged into |
Corrected a mistake in the documentation for the Spring Architecture where it was mentioned that RequestCacheAwareFilter is used to save the HttpServletRequest instead of the ExceptionTranslationFilter
The issue id for this pull request is 14855
#14855