Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a mistake in the documentation for the Spring Architecture #14860

Closed
wants to merge 2 commits into from

Conversation

angel-gruevski
Copy link
Contributor

Corrected a mistake in the documentation for the Spring Architecture where it was mentioned that RequestCacheAwareFilter is used to save the HttpServletRequest instead of the ExceptionTranslationFilter

The issue id for this pull request is 14855

#14855

…where it was mentioned that RequestCacheAwareFilter is used to save the HttpServletRequest instead of the ExceptionTranslationFilter
@pivotal-cla
Copy link

@angel-gruevski Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@angel-gruevski Thank you for signing the Contributor License Agreement!

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @angel-gruevski! In addition to my inline feedback, will you please adjust your Git commit message to follow the following format:

Correct Documentation

Your description, if any, wrapping about every 60 characters
or so.

Closes gh-14855

That syntax helps so that, first, the associated ticket is closed automatically, and second, the Git history is easier to read.

docs/modules/ROOT/pages/servlet/architecture.adoc Outdated Show resolved Hide resolved
@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 16, 2024
@jzheaux jzheaux self-assigned this Apr 16, 2024
Correct Documentation

Corrected a mistake in the documentation related to RequestCacheAwareFilter

Closes spring-projectsgh-14855
Copy link
Contributor Author

@angel-gruevski angel-gruevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the corrections

@jzheaux
Copy link
Contributor

jzheaux commented Apr 25, 2024

@angel-gruevski, thanks so much for the updates. Will you please do one more cleanup item for me and squash your commits?

@marcusdacoregio
Copy link
Contributor

Thanks @angel-gruevski. This is now merged into 5.8.x via ce995a0 and forward-ported to 6.1.x, 6.2.x and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: waiting-for-feedback We need additional information before we can continue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants