Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SamlAuthenticationProvider should propagate actual validation errors #7375

Closed
fhanik opened this issue Sep 5, 2019 · 0 comments · Fixed by #7477
Closed

SamlAuthenticationProvider should propagate actual validation errors #7375

fhanik opened this issue Sep 5, 2019 · 0 comments · Fixed by #7477
Assignees
@fhanik
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone
5.2.0

Comments

@fhanik
Copy link
Contributor

fhanik commented Sep 5, 2019 •
edited
Loading

Per #7260 (comment) it may be a good idea to propagate an Saml2AuthenticationException in the authentication provider with validation details.

This can be caught in the authentication entry point, or other location, to influence UI rendering or messaging.
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels Sep 5, 2019
@jzheaux jzheaux added this to the 5.2.0 milestone Sep 5, 2019
@jzheaux jzheaux changed the title SamlAuthenticationProvider can expose actual validation errors SamlAuthenticationProvider should propagate actual validation errors Sep 5, 2019
@fhanik fhanik added in: saml2 An issue in SAML2 modules and removed in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Sep 6, 2019
This was referenced Sep 6, 2019
Closed
Merged
@fhanik fhanik self-assigned this Sep 24, 2019
@fhanik fhanik closed this as completed in d472e99 Sep 24, 2019
fhanik added a commit that referenced this issue Sep 24, 2019
@fhanik
Merge pull request #7432 from fhanik/feature/propagate_saml_authentic…
e9619fb 
…ation_exception

Propagate saml authentication exception #7375

Fixes gh-7375
@fhanik fhanik mentioned this issue Sep 25, 2019
Merged
fhanik added a commit to fhanik/spring-security that referenced this issue Sep 27, 2019
@fhanik
SAML Assertion validation should propagate errors: spring-projects#7375…
22da2b4 
… and spring-projects#7375

Fixes spring-projectsgh-7377
Fixes spring-projectsgh-7375

spring-projects#7377
spring-projects#7375

Clean up code

- Authentication request factory should only throw Saml2Exception
- OpenSamlImplementation should only throw Saml2Exception
- Move the OpenSamlImplementation package private methods to the right
section
fhanik added a commit that referenced this issue Sep 27, 2019
@fhanik
Merge pull request #7477 from fhanik/feature/propagate_saml_authentic…
e6d40e8 
…ation_exception

propagate saml authentication exception #7375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhanik fhanik

Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

propagate saml authentication exception #7375 fhanik/spring-security
2 participants
@fhanik @jzheaux