Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagate saml authentication exception #7375 #7477

Merged
merged 2 commits into from
Sep 27, 2019
Merged

propagate saml authentication exception #7375 #7477

merged 2 commits into from
Sep 27, 2019

Conversation

fhanik
Copy link
Contributor

@fhanik fhanik commented Sep 25, 2019

PowerMock removed as a test dependency. Testing converted using real data.

Fixes gh-7375

@fhanik fhanik added the in: saml2 An issue in SAML2 modules label Sep 25, 2019
@fhanik fhanik added this to the 5.2.0 milestone Sep 25, 2019
@fhanik fhanik requested a review from jzheaux September 25, 2019 19:47
@fhanik fhanik self-assigned this Sep 25, 2019
jzheaux
jzheaux requested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left just one comment inline. Nice work removing the test dependency.

...g/springframework/security/saml2/provider/service/authentication/TestSaml2CryptoSupport.java Outdated Show resolved Hide resolved
@fhanik
OpenSAML expects type long representing millis for response time va…
b6a057a 
…lidation skew

Fixes spring-projectsgh-7448

spring-projects#7448
@fhanik
SAML Assertion validation should propagate errors: spring-projects#7375…
22da2b4 
… and spring-projects#7375

Fixes spring-projectsgh-7377
Fixes spring-projectsgh-7375

spring-projects#7377
spring-projects#7375

Clean up code

- Authentication request factory should only throw Saml2Exception
- OpenSamlImplementation should only throw Saml2Exception
- Move the OpenSamlImplementation package private methods to the right
section
@fhanik fhanik force-pushed the feature/propagate_saml_authentication_exception branch from e283887 to 22da2b4 Compare September 27, 2019 16:08
@fhanik fhanik merged commit e6d40e8 into spring-projects:master Sep 27, 2019
@fhanik fhanik deleted the feature/propagate_saml_authentication_exception branch September 27, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux requested changes

Assignees

@fhanik fhanik

Labels
in: saml2 An issue in SAML2 modules
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

SamlAuthenticationProvider should propagate actual validation errors
2 participants
@fhanik @jzheaux